Closed
Bug 682536
Opened 13 years ago
Closed 13 years ago
Showing/hiding the conditional forward button shouldn't resize the search bar
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 10
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
(deleted),
patch
|
shorlander
:
review+
|
Details | Diff | Splinter Review |
No description provided.
People on IRC are already asking for a way to disable conditional forward button on nightly builds of linux since it landed there on bug 677027, likely due to more use-cases than just the searchbar.
For example, the case of people taking advantage of the great Firefox strength in customisability of moving many UI items onto the same bar as the back/forward button, would this detect and prevent such customised UI elements from jumping? I don't want to see this blowing up into more negative tech press.
Comment 2•13 years ago
|
||
This is indeed an annoying side effect, plus the sliding is jerky for me.
screencast on today's build:
http://video.chevrel.org/out.ogv
I don't think UI elements should move without a good reason (like tab reordering), this is very visually distracting.
Comment 3•13 years ago
|
||
This is happening now on Nightly-Windows (10/11/2011) with a clean profile.
OS: Linux → All
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Jared Wein [:jwein] from comment #3)
> This is happening now on Nightly-Windows (10/11/2011) with a clean profile.
Please file a new bug.
OS: All → Linux
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #4)
> (In reply to Jared Wein [:jwein] from comment #3)
> > This is happening now on Nightly-Windows (10/11/2011) with a clean profile.
>
> Please file a new bug.
I filed bug 694084.
Assignee | ||
Comment 6•13 years ago
|
||
Attachment #567445 -
Flags: review?(shorlander)
Assignee | ||
Updated•13 years ago
|
Attachment #567445 -
Flags: review?(dolske)
Comment 7•13 years ago
|
||
Comment on attachment 567445 [details] [diff] [review]
patch
With a fresh profile this still resizes the search bar until you manually resize the urlbar/searchbar splitter. I noticed the same thing on the Windows and OSX versions.
Is there any way around that?
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to Stephen Horlander from comment #7)
That's expected as far as this patch is concerned. Bug 694084 covers the rest.
Updated•13 years ago
|
Attachment #567445 -
Flags: review?(shorlander) → review+
Assignee | ||
Updated•13 years ago
|
Attachment #567445 -
Flags: review?(dolske)
Comment 9•13 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #8)
> (In reply to Stephen Horlander from comment #7)
> That's expected as far as this patch is concerned. Bug 694084 covers the
> rest.
Awesome, thank you!
Assignee | ||
Comment 10•13 years ago
|
||
Target Milestone: --- → Firefox 10
Comment 11•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•