Closed
Bug 682683
Opened 13 years ago
Closed 13 years ago
Addon test failure - TypeError: descriptor 'lower' requires a 'str' object but received a 'unicode'
Categories
(Testing :: Talos, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nthomas, Assigned: anodelman)
References
Details
(Whiteboard: [mozbase])
Attachments
(1 file)
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
eg: Flashblock - http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/addontester-linux/1313106963/addontester_fedora_test-addon-build24.txt.gz Running test ts: Started Sun, 28 Aug 2011 01:29:08 Traceback (most recent call last): File "run_tests.py", line 540, in <module> test_file(arg, screen, amo) File "run_tests.py", line 485, in test_file browser_dump, counter_dump, print_format = mytest.runTest(browser_config, test) File "/home/cltbld/talos-slave/talos-data/talos/ttest.py", line 234, in runTest profile_dir, temp_dir = self.createProfile(test_config['profile_path'], browser_config) File "/home/cltbld/talos-slave/talos-data/talos/ttest.py", line 134, in createProfile browser_config['extensions']) File "/home/cltbld/talos-slave/talos-data/talos/ffsetup.py", line 247, in CreateTempProfileDir self.install_addon(profile_dir, addon) File "/home/cltbld/talos-slave/talos-data/talos/ffsetup.py", line 196, in install_addon if (str.lower(unpack) == 'true'): #install addon unpacked TypeError: descriptor 'lower' requires a 'str' object but received a 'unicode' Depends on bug 680962 only in the sense that we discovered it there, and RelEng has to fix that to get regular addon perf tests.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → anodelman
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #556554 -
Flags: review?(jmaher)
Comment 2•13 years ago
|
||
Comment on attachment 556554 [details] [diff] [review] [checked in]convert unicode to string Review of attachment 556554 [details] [diff] [review]: ----------------------------------------------------------------- can you fix this in mozmill also: https://github.com/mozautomation/mozmill/blob/master/mozprofile/mozprofile/addons.py#L160
Attachment #556554 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 556554 [details] [diff] [review] [checked in]convert unicode to string changeset: 250:ba94d2a40f17
Attachment #556554 -
Attachment description: convert unicode to string → [checked in]convert unicode to string
Updated•13 years ago
|
Whiteboard: [mozbase]
Comment 4•13 years ago
|
||
Trying to reproduce for mozmill.
Comment 5•13 years ago
|
||
So mozprofile -a https://addons.mozilla.org/firefox/downloads/latest/433/addon-433-latest.xpi works as expected. Does this mean there isn't an issue? Or does anyone have a repro case?
Comment 6•13 years ago
|
||
So Mozprofile doesn't unpack things selectively ATM : bug 662683 . This can/will become an issue if this happens.
Assignee | ||
Comment 7•13 years ago
|
||
Change deployed.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•