Closed
Bug 682919
Opened 13 years ago
Closed 13 years ago
"-moz-transform-style: fixed" is parsed as preserve-3d
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: jruderman, Unassigned)
References
Details
(Keywords: testcase, Whiteboard: [inbound])
Attachments
(3 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
"-moz-transform-style: fixed" is parsed as "preserve-3d". I'm guessing this isn't intentional, based on looking at patch 14a in bug 505115.
|
||
Comment 1•13 years ago
|
||
I can see the same behaviour here, but I'm not sure why.
I tried adding the above tests to catch this behaviour, and they pass.
|
Reporter | |
Comment 2•13 years ago
|
||
Maybe you need "eCSSKeyword_UNKNOWN,-1" at the end of kTransformStyleKTable. (The table above it also seems to be missing that. Not the sanest API.)
http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSProps.cpp#590
|
||
Comment 3•13 years ago
|
||
Yes, that's needed. Not sure what alternative API you'd suggest; you either need a terminator or a length.
|
|
Reporter | |
Comment 4•13 years ago
|
||
You could compute the length using NS_ARRAY_LENGTH instead of specifying it.
|
|
||
Comment 5•13 years ago
|
||
I suppose so, but then we'd need to pass that length around in a whole bunch of places, or add a structure wrapping the length and a pointer to the list (probably the better option).
|
|
||
Comment 7•13 years ago
|
||
Comment on attachment 563929 [details] [diff] [review]
Add eCSSKeyword_UNKNOWN
r=dbaron
Attachment #563929 -
Flags: review?(dbaron) → review+
|
|
||
Comment 8•13 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 9•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•