Closed
Bug 683441
Opened 13 years ago
Closed 13 years ago
Sign NSS libraries from packager.mk
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: fixed-in-bs)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
For some reason that is beyond me, osx64 crashes in shlibsign when it happens from security/manager when jemalloc is enabled *and* bug 680440 is applied. As bug 680440 will land and jemalloc is going to be enabled, this is going to be a problem. It turns out shlibsign does *not* crash when called from packager.mk.
We actually also have code for signing in packager.mk, because we need to on universal builds, and we also need to on builds where we strip the binaries. In the end, we just can completely get rid of the signing in security/manager and unconditionally sign in packager.mk.
Assignee | ||
Comment 1•13 years ago
|
||
Testing this on try:
http://tbpl.allizom.org/?usebuildbot=1&tree=Try&rev=d2406ac8bc34
Attachment #557098 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 2•13 years ago
|
||
The part actually avoiding the chk creation from nss was missing.
http://tbpl.allizom.org/?usebuildbot=1&tree=Try&rev=d0cb5651b586
Attachment #557105 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•13 years ago
|
Attachment #557098 -
Attachment is obsolete: true
Attachment #557098 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 3•13 years ago
|
||
Refreshed against current m-c
Attachment #557317 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•13 years ago
|
Attachment #557105 -
Attachment is obsolete: true
Attachment #557105 -
Flags: review?(ted.mielczarek)
Comment 4•13 years ago
|
||
Comment on attachment 557317 [details] [diff] [review]
Always sign NSS libraries from packager.mk
Review of attachment 557317 [details] [diff] [review]:
-----------------------------------------------------------------
::: security/manager/Makefile.in
@@ +234,5 @@
> # Disable building of the test programs in security/nss/lib/zlib
> DEFAULT_GMAKE_FLAGS += PROGRAMS=
>
> +# Disable creating .chk files. They will be generated from packager.mk
> +DEFAULT_GMAKE_FLAGS += CHECKLOC=
Can you put a comment here about how we should use the stuff from bug 681624 if it lands?
Attachment #557317 -
Flags: review?(ted.mielczarek) → review+
Updated•13 years ago
|
Assignee: nobody → mh+mozilla
Assignee | ||
Comment 5•13 years ago
|
||
Whiteboard: fixed-in-bs
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•