Closed
Bug 684016
Opened 13 years ago
Closed 11 years ago
gBrowser.addProgressListener call with a 2nd argument throws uninformative error
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 26
People
(Reporter: a2414578, Assigned: dao)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
When gBrowser.addProgressListener gets called with 2nd argument, we get an uninformative error in the error console:
Error: gBrowser.addProgressListener was called with a second argument, which is not supported. See bug 608628.
Source File: chrome://browser/content/tabbrowser.xml
Line: 1871
How am I supposed to know who was the caller?
var caller = Components.stack.caller;
throw new Error(
"...",
caller.filename,
caller.lineNumber
);
or Components.utils.reportError(new Error( ... ));
Assignee | ||
Comment 1•13 years ago
|
||
NS_ASSERT actually displays the stack in non-release builds:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/debug.js#95
Reporter | ||
Comment 2•13 years ago
|
||
But couldn't you make that error itself in the error console be more informative and make it tell who was the caller?
Reporter | ||
Comment 3•13 years ago
|
||
How I'm tired of these errors!
Error: gBrowser.addProgressListener was called with a second argument, which is not supported. See bug 608628.
Source File: chrome://browser/content/tabbrowser.xml
Line: 1877
And how the f- do I get know who called that gBrowser.addProgressListener with a f-ing second argument? How am I supposed to investigate that f-ing error?
Why this bug is still UNCO?
Reporter | ||
Comment 4•13 years ago
|
||
bump
There's still no meaningful error message for this. Took me half an hour to find out which extension caused this error. Playing the "half enabled, half disabled"-game with 50+ extension is really funny...
Assignee | ||
Updated•11 years ago
|
Keywords: regression
Assignee | ||
Updated•11 years ago
|
Severity: major → normal
Assignee | ||
Comment 6•11 years ago
|
||
Assignee: nobody → dao
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #791314 -
Flags: review?(gavin.sharp)
Updated•11 years ago
|
Attachment #791314 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in
before you can comment on or make changes to this bug.
Description
•