Pushes to mozilla-inbound which touch files in js/ trigger some SpiderMonkey shell builds/tests. Because of bug 678685, tbpl was being told that they were on the "integration/mozilla-inbound" branch, so it wasn't showing them. Starting with https://tbpl.mozilla.org/?tree=Mozilla-Inbound&usebuildbot=1&rev=deec82bfd178 it's being told they are on the mozilla-inbound branch, so it is showing them. Several of them are permared (from filed bugs), so they need to be hidden, but the tree admin panel doesn't list any of them, so they can't be hidden from usebuildbot=1 (and because of bug 684154, where they don't upload logs so usebuildbot can't say anything about them other than that they were red or green, they can't even be reasonably starred while showing permared - I probably know what the failures are, maybe, if they are the same ones they were the last time I saw the SpiderMonkey builds, before I stopped using tinderbox-based tbpl, but who knows?).

On swatinem.de, those builders have the branch "idle" in mysql. No idea where that comes from. In the import script, we probably need an UPDATE for the branch, we currently only update the buildername.

Do you mean like this? Is there a releng bug in here too then? Seems odd that branch would be "idle"... I took a peek in the JSON and the only place I see this is "category" in each "builder" entry: { "builders": { "10001": { "category": "mozilla-central", ... }, "33953": { "category": "idle", ... } }

Comment on attachment 557904 [details] [diff] [review] set branch and buildername on update Review of attachment 557904 [details] [diff] [review]: ----------------------------------------------------------------- Lets hope this does the job.

(In reply to Arpad Borsos (Swatinem) from comment #3) > Comment on attachment 557904 [details] [diff] [review] > set branch and buildername on update > > Review of attachment 557904 [details] [diff] [review]: > ----------------------------------------------------------------- > > Lets hope this does the job. I have been testing and haven't seen any updates; I'll ping the releng folks.

Comment on attachment 559025 [details] [diff] [review] [buildbot-configs] set branch instead of 'idle' for SpiderMonkey and Valgrind http://hg.mozilla.org/build/buildbotcustom/rev/9a5ae2438012 This will go live the next time we push buildbot changes into production. catlee is on buildduty this week and will be coordinating that.

Comment on attachment 557904 [details] [diff] [review] set branch and buildername on update Pushed: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/f07761a5a015

Reassign to catlee to push attachment 559025 [details] [diff] [review] to buildbot prod per comment 6

Merged to production and reconfigured.

I still see "category": "idle" for these builders in http://build.mozilla.org/builds/builds-4hr.js.gz, should this be fixed now? "47344": { "category": "idle", "master_id": 34, "name": "mozilla-inbound_macosx64_spidermonkey-warnaserr",

(In reply to Robert Helmer [:rhelmer] from comment #10) > I still see "category": "idle" for these builders in > http://build.mozilla.org/builds/builds-4hr.js.gz, should this be fixed now? > > "47344": { > "category": "idle", > "master_id": 34, > "name": "mozilla-inbound_macosx64_spidermonkey-warnaserr", armen, catlee, rhelmer: what's left to do here?

(In reply to John O'Duinn [:joduinn] from comment #11) > (In reply to Robert Helmer [:rhelmer] from comment #10) > > I still see "category": "idle" for these builders in > > http://build.mozilla.org/builds/builds-4hr.js.gz, should this be fixed now? > > > > "47344": { > > "category": "idle", > > "master_id": 34, > > "name": "mozilla-inbound_macosx64_spidermonkey-warnaserr", > > > > armen, catlee, rhelmer: what's left to do here? TBPL expects the branch name to be in "category", not "idle. IIRC the patch in this bug was supposed to correct this but it is still happening AFAICT.

I'm pretty sure that all is well in the buildbot master, based on dumping the builders, and using waterfall?category=mozilla-inbound and getting spidermonkey. However if I look at statusdb.builders then the mozilla-inbound%spidermonkey% builders mostly (but not exclusively) have the 'idle' for category. I suspect we're not updating the category in update_from_files.py, although we're not far off based on the code near http://hg.mozilla.org/build/buildbotcustom/file/default/bin/update_from_files.py#l185 and in updateBuilderSlaves().

I think this should do what we want, from reading the surrounding code and sqlalchemy docs, but I don't know how I'd go about testing it.

Curiously enough, when I just looked, 3 of the 6 10.6 builds and 1 of the 2 Windows builds I need to hide were there.

Interesting. When I looked less than 2 hours ago only 4 of the 60 rows in the builders table had the right category (there are N*M rows for N builders x M masters, for masters that have actually done one of those jobs). Now there are 24 of 60. coop did a master reconfig in between, so perhaps the category hadn't been updated in the builder file before that. My patch might not be required at all - catlee will know, I bet.

Comment on attachment 560221 [details] [diff] [review] [buildbotcustom] save category changes catlee confirmed that a second reconfig is required to fix up the category in the builder file, just like bug 686238, so this patch isn't necessary.

We had 40/60 with the right category, so I just went ahead and updated the db directly for the last 20.

Success! Everything now appears, and our long national nightmare of (visible) permared is over :)