Closed
Bug 684315
Opened 13 years ago
Closed 13 years ago
Remove private browsing code from nsEditorSpellCheck.cpp
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: arno, Assigned: arno)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Since bug 679784 is fixed, it's possible to remove private browsing mode handling from nsEditorSpellCheck.cpp
I had deliberately not done that in bug 679784 to leave bug 679784 and bug 678842 independent. So, in case, one of them has to be backouted for whatever reason, this can be done without touching the other one.
|
Assignee | |
Updated•13 years ago
|
|
||
Comment 1•13 years ago
|
||
Are you interested in taking this, Arno?
|
|
Assignee | |
Comment 2•13 years ago
|
||
patch proposal.
Here is try server result:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&tree=Try&rev=226e2af677ba
Assignee: nobody → arno
Attachment #558049 -
Flags: review?(ehsan)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 558049 [details] [diff] [review]
patch proposal
Review of attachment 558049 [details] [diff] [review]:
-----------------------------------------------------------------
r=me withe the comment below addressed.
::: editor/composer/src/nsEditorSpellCheck.cpp
@@ +747,5 @@
>
> void
> nsEditorSpellCheck::ShutDown() {
> + if (gDictionaryStore) {
> + nsMemory::Free(gDictionaryStore);
gDictionaryStore is allocated using operator new, so you should deallocate it using operator delete.
Attachment #558049 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #558049 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•13 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla9
|
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•