Closed
Bug 684318
Opened 13 years ago
Closed 13 years ago
IonMonkey: Don't enter Ion if recording traces
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: dvander, Assigned: dvander)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
Failing these tests:
js1_5/Regress/regress-456470.js
js1_5/Regress/regress-456494.js
Because we execute Ion code while recording traces, which confuses the trace recorder.
|
Assignee | |
Comment 1•13 years ago
|
||
We're not going to test with the tracer enabled, so the problem here is just test cases that explicitly enable the tracer. In this case let's just avoid entering Ion code.
Attachment #557913 -
Flags: review?(sstangl)
|
||
Updated•13 years ago
|
Attachment #557913 -
Flags: review?(sstangl) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #557948 -
Flags: review?(sstangl)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 557913 [details] [diff] [review]
fix
Whoops, forgot to comment: the new patch hardcodes the tracer to be off, instead.
Attachment #557913 -
Attachment is obsolete: true
|
|
||
Updated•13 years ago
|
Attachment #557948 -
Flags: review?(sstangl) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•