Closed
Bug 684362
Opened 13 years ago
Closed 13 years ago
IonMonkey: Crash building SSA for an infinite loop
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: dvander, Assigned: dvander)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #557955 -
Flags: review?(sstangl)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 557955 [details] [diff] [review]
fix
Review of attachment 557955 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/IonBuilder.cpp
@@ +707,5 @@
>
> current = successor;
> +
> + // An infinite loop (for (;;) { }) will not have a successor.
> + if (!current)
Would prefer (!successor) for clarity.
Attachment #557955 -
Flags: review?(sstangl) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
http://hg.mozilla.org/projects/ionmonkey/rev/1643eac86ad1
(re: nit, the !current .. return Ended pattern is really prevalent, it should probably actually be a helper and tail called.)
|
|
Assignee | |
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•