BUILD: 2001-02-11-06 linux and 2001-02-10 windows. STEPS TO REPRODUCE: 1) open bookmark manager 2) look at the "File Bookmark" button ACTUAL RESULTS: It looks inset. EXPECTED RESULTS: It looks like the other buttons. NOTE: The problem goes away after clicking on the "File Bookmark" button... so it's just the initial state that's screwed up.

Worksforme on build 20010227, Windows 98. Boris, is this problem still occuring?

worksforme with a new profile. Copying my old bookmarks file to the new profile makes the error reappear. No JS errors errors in the text console... Attaching bookmark file in question.

I've seen this is recent (c. 20010306) builds. I 'll report more when I see it again.

I attached a mouseover to the "File" button which claimed that open="true" before I had clicked it... something is making it "open" when it shouldn't be.

Good catch, neil! The problem is here (line 98 in bookmarks.js): var node = document.getElementById("NC:BookmarksRoot"); if (node.localName == "menubutton") node.removeAttribute("open"); Since the first element that has 'ref="NC:BookmarksRoot"' is actually the 'File Bookmark' item in the Edit menu, node.localName is "menu" and the removeAttribute is never executed. Even if it were, 'node' is the wrong node... patch coming up.

Patch looks okay, r=jag. Ben, did you have this one in your tree yet?

Ben posted a large bookmark patch to bug 76502 which I applied locally. That patch cures this bug for me, as the File-button is no longer depressed (which it always used to be for me before). The patch is http://bugzilla.mozilla.org/showattachment.cgi?attach_id=31711

Boris, any idea how you managed to do that patch? I'm not seeing the code anywhere! Also the bug seems fixed to me. ANy thoughts?

Fun... The code I changed was removed as part of Ben's fix to bug 17920. As far as I can tell by reading that patch (it's kinda long...) this bug should be fixed by it.

Well I did some further poking around and I found this: In my localstore.rdf there are the following entries: <NC:persist resource="NC:BookmarksRoot"/> <RDF:Description about="NC:BookmarksRoot"> <open>true</open> </RDF:Description> When I deleted these the file menu stops looking open. How the entries got there I don't know. Why it affects the file menu I don't know either. But that explains the code to remove it. As you're changing the menubutton as a button, the problem won't arise.

Fixed, no longer problem now that this is a button (not a menubutton) which launches a dialog.

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31. if you think this particular bug is not fixed, please make sure of the following before reopening: a. retest with a *recent* trunk build. b. query bugzilla to see if there's an existing, open bug (new, reopened, assigned) that covers your issue. c. if this does need to be reopened, make sure there are specific steps to reproduce (unless already provided and up-to-date). thanks! [set your search string in mail to "AmbassadorKoshNaranek" to filter out these messages.]