Closed
Bug 685480
Opened 13 years ago
Closed 13 years ago
Port bug 680440 and bug 677501 to c-c
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(thunderbird9 fixed, seamonkey2.6 fixed)
RESOLVED
FIXED
Thunderbird 9.0
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
standard8
:
review+
Callek
:
feedback+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #559083 -
Flags: review?(bugspam.Callek)
Comment 2•13 years ago
|
||
Comment on attachment 559083 [details] [diff] [review]
Port bug 680440 and bug 677501 to c-c
A quick skim vs the dep bugs looks good here, I didn't verify character by character on these changes though. So just f+ for now.
Adding Mark to the review list, since he is pushing this to try, he can review before me possibly too. Only one review is necessary for this to land (in sync with the b-s merge)
Thanks.
Attachment #559083 -
Flags: review?(mbanner)
Attachment #559083 -
Flags: review?(bugspam.Callek)
Attachment #559083 -
Flags: feedback+
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #560154 -
Flags: review?(mbanner)
Assignee | ||
Comment 4•13 years ago
|
||
Both patches are being tested on try:
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=5a8ad6c8c34d
Assignee | ||
Updated•13 years ago
|
Attachment #560154 -
Flags: feedback?(bugspam.Callek)
Assignee | ||
Comment 5•13 years ago
|
||
*sigh* the windows build started so late that it picked a different commit from b-s, one that has bug 685798 landed, and that failed to build on that c-c try because I had reverted the c-c part of that bug because the b-s commit that was being picked before didn't have it. So we still don't have a windows result :(
Respinning.
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=c30295b18eac
Assignee | ||
Comment 6•13 years ago
|
||
Attachment #560344 -
Flags: review?(mbanner)
Assignee | ||
Updated•13 years ago
|
Attachment #560154 -
Attachment is obsolete: true
Attachment #560154 -
Flags: review?(mbanner)
Attachment #560154 -
Flags: feedback?(bugspam.Callek)
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 560344 [details] [diff] [review]
Also port bug 584474, bug 644987 and bug 683875
This should be the one, fixing linking problems on windows due to how expand_libs did change some things.
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=2194841463ef
Attachment #560344 -
Flags: feedback?(bugspam.Callek)
Updated•13 years ago
|
Assignee: nobody → mh+mozilla
Product: SeaMonkey → MailNews Core
QA Contact: build-config → build-config
Updated•13 years ago
|
Attachment #559083 -
Flags: review?(mbanner)
Attachment #559083 -
Flags: review?(bugspam.Callek)
Attachment #559083 -
Flags: review+
Comment 8•13 years ago
|
||
Comment on attachment 560344 [details] [diff] [review]
Also port bug 584474, bug 644987 and bug 683875
Ok, I've not looked at this in precise detail, but it looks fine, especially with the try build being green.
Attachment #560344 -
Flags: review?(mbanner) → review+
Comment 9•13 years ago
|
||
Landed as: http://hg.mozilla.org/comm-central/rev/5359e5422f12 and http://hg.mozilla.org/comm-central/rev/eb19b4c513e0
(In reply to Mark Banner (:standard8) from comment #8)
> Comment on attachment 560344 [details] [diff] [review]
> Also port bug 584474, bug 644987 and bug 683875
>
> Ok, I've not looked at this in precise detail, but it looks fine, especially
> with the try build being green.
Followed by:
http://hg.mozilla.org/comm-central/rev/8094d209fa88
(I clobbered SeaMonkey win builders just in case)
Status: NEW → RESOLVED
Closed: 13 years ago
status-seamonkey2.6:
--- → fixed
status-thunderbird9:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
Updated•13 years ago
|
Attachment #560344 -
Flags: feedback?(bugspam.Callek)
Updated•13 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•