Closed
Bug 685593
Opened 13 years ago
Closed 13 years ago
remove unused argument gcKind from Debugger::markAllIteratively
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
The argument gcKind is unused, and it makes moving markAllIteratively out of MarkAndSweep into MarkRuntime, which I am considering doing as part of some GC cleanup, impossible.
|
Assignee | |
Comment 1•13 years ago
|
||
I haven't tested this yet, but it compiles, so there shouldn't be a problem. I'll try server it before I land it.
Attachment #559216 -
Flags: review?(jorendorff)
|
||
Updated•13 years ago
|
Attachment #559216 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
Try run for 51307568846d is complete.
Detailed breakdown of the results available here:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=51307568846d
Results (out of 146 total builds):
exception: 2
success: 141
warnings: 2
failure: 1
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/amccreight@mozilla.com-51307568846d
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
There is still no actual alliteration in this function, but I guess that's a separate bug.
You need to log in
before you can comment on or make changes to this bug.
Description
•