Nathan Froyd [:froydnj] Assignee
	Description • 13 years ago

After the fix for bug 668392, the getMetadata function in TelemetryPing.js is unused.  Trivial patch for deletion coming up.

	Nathan Froyd [:froydnj] Assignee
	Comment 1 • 13 years ago

Trivial patch.

	Marco Bonardo [:mak]
	Comment 2 • 13 years ago

Comment on attachment 559472 [details] [diff] [review]
remove now-unused getMetadata function

Review of attachment 559472 [details] [diff] [review]:
-----------------------------------------------------------------

it looks fine, the other patch moved the method due to the need of using a local property but forgot to remove the original.
I'm not a peer of this component, but Taras is cc-ed and I assume he saw the review request and is fine with it.

	Nathan Froyd [:froydnj] Assignee
	Comment 3 • 13 years ago

Scratch that checkin-needed, looks like trunk somehow lost the local property?

	Marco Bonardo [:mak]
	Comment 4 • 13 years ago

bug 668392 has indeed been backed out, so you may ask there to remove the unused function next time it will be pushed.

	Nathan Froyd [:froydnj] Assignee
	Comment 5 • 13 years ago

Bah, I forgot about pinging here.

On the plus side, we're fixing an actual bug now, as the patch for bug 668392 removed our collection of CPU capability fields.

	(dormant account)
	Comment 6 • 13 years ago

Comment on attachment 574366 [details] [diff] [review]
remove unused getMetadata and update sysinfo fields

i should not be allowed to write code sometimes

	Nathan Froyd [:froydnj] Assignee
	Comment 7 • 13 years ago

checkin-needed for real this time.

	Dão Gottwald [:dao]
	Comment 8 • 13 years ago

http://hg.mozilla.org/integration/mozilla-inbound/rev/27c0d94ef09e

	Ed Morley [:emorley]
	Comment 9 • 13 years ago

https://hg.mozilla.org/mozilla-central/rev/27c0d94ef09e