Closed
Bug 685927
Opened 13 years ago
Closed 13 years ago
Make stl-wrappers more lenient when compiling ObjC with GCC
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla10
People
(Reporter: ted, Assigned: ted)
References
Details
(Whiteboard: [iOS] fixed-in-bs)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
Apple's GCC apparently has a bug where it doesn't honor -fno-exceptions when compiling ObjC, so you wind up with __EXCEPTIONS defined no matter what you do. This blows up in our stl wrappers, of course. We don't hit this on desktop OS X because Apple's GCC has a different bug there related to visibility which causes us to not use the stl wrappers at all.
I have a patch that lets us work around this. I think if we move to clang this will all go away.
Assignee | ||
Updated•13 years ago
|
Whiteboard: [iOS]
Assignee | ||
Comment 1•13 years ago
|
||
This skips the #error case when we're compiling ObjC with GCC.
Attachment #559506 -
Flags: review?(jones.chris.g)
Sorry for the review latency, but wasn't the guess last time we talked that there was something iOS-specific (either different compiler build or different build flag) triggering this problem? If so, could we make this workaround contingent on iOS for the time being?
Assignee | ||
Comment 3•13 years ago
|
||
I believe it's probably a slightly different GCC (hard to tell with Apple's GCC versioning), since it passes the visibility test. Is it really worth it? We're unlikely to ever get an Apple GCC for x86/x86-64 that passes the test and hits this bug, we're more likely to switch to clang.
All I'm suggesting is to add __iOS__ or whatever to the guard here.
Assignee | ||
Comment 5•13 years ago
|
||
Okay, this makes it iOS-specific.
Attachment #565996 -
Flags: review?(jones.chris.g)
Assignee | ||
Updated•13 years ago
|
Attachment #559506 -
Attachment is obsolete: true
Attachment #559506 -
Flags: review?(jones.chris.g)
Updated•13 years ago
|
Attachment #565996 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Comment 6•13 years ago
|
||
Whiteboard: [iOS] → [iOS] fixed-in-bs
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•