Closed
Bug 686429
Opened 13 years ago
Closed 13 years ago
test cases for MIME headers need refactoring
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: julian.reschke, Assigned: julian.reschke)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(1) They feed the header name into the call, but the function being tested expects only the feed value. That the tests seem to do what they should do seems to be pure luck.
(2) Currently the tests reside in multiple JS files due to historic reasons; consolidate them in a single file.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → julian.reschke
Target Milestone: --- → mozilla10
|
|
Assignee | |
Comment 1•13 years ago
|
||
(In reply to Julian Reschke from comment #0)
> (1) They feed the header name into the call, but the function being tested
> expects only the feed value. That the tests seem to do what they should do
> seems to be pure luck.
> ...
For the base class, this was already done for bug 610054.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Consolidates all Content-Disposition tests in test_MIME_params.js.
Also: all tests check both the filename and the disposition type.
Attachment #565745 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 565745 [details] [diff] [review]
Proposed patch
(patch is on top of 610054)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 565745 [details] [diff] [review]
Proposed patch
> +// (note: 5987-mode node yet in use, see bug 601933)
"note yet in use", yes?
r=me
Attachment #565745 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Proposed patch with typo in comment fixed ("node" ->" not")
Attachment #565745 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Attachment #566460 -
Flags: review?(bzbarsky)
|
|
||
Updated•13 years ago
|
Attachment #566460 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ceb6b4df17d5
FWIW, having your name and the reviewer in the patch is helpful.
|
||
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•