as per discussions with dkl, we will be changing the default setting for "Include comments when performing quick searches (slower)" from "on" to "off". the reasoning is simple to deduce: searching all comments on bmo is way too slow, and most people don't know about this option. i will make some ui changes which i'll attach here when complete to either notify people of the existence of the preference on the search page itself, or provide a checkbox to toggle it on a search-by-search basis. once the setting has been changed, i'll blog about it to raise awareness.

Personally I would not like to see a checkbox added to the quicksearch field at the top of each page since users can just do "comment:sometext" if they prefer comments to be searched. Two possible places we talked about last week: 1. Add checkbox to the Simple Search page to allow overriding the comment quick search setting per search. 2. Maybe add a checkbox to the top of the buglist.cgi page asking if they want to re-run the current search with comments enabled if they a) have comment quick search disabled and b) did not turn on comment search in some other way (ie. "comment:sometext" for quicksearch, comment checkbox on simple search, or comment text field on advanced search). Either 1 or 2 would allow for storing saved searches as well that have the comments on by default. dkl

(In reply to David Lawrence [:dkl] from comment #1) > Personally I would not like to see a checkbox added to the quicksearch field > at the top of each page since users can just do "comment:sometext" if they > prefer comments to be searched. sorry i wasn't clear in my initial description; when talking about UI changes to the search page, i was referring to changes to the simple search tab only, not to the header and footer (ie. option 1 from your comment).

after starting to look at this, i've realised that "simple search" doesn't use quicksearching (instead it's a advanced search with fewer fields) (see bug 490549). i've raised bug 687774 to deal with the 'simple search' part. for this bug i experimented a while ago with placing the quicksearch form at the top of a buglist results page to allow for quicker fine tuning of the results. i'll update that code and add a comments checkbox.

(In reply to Byron Jones ‹:glob› from comment #4) > for this bug i experimented a while ago with placing the quicksearch form at > the top of a buglist results page to allow for quicker fine tuning of the > results. i'll update that code and add a comments checkbox. I like that. Bonus points for removing the quick search field from the header/footer on buglist.cgi. dkl

this is about changing the default, which is very different from bug 803058.

Now that we have bug 803058, please can we do this? :-) (With blog post about it and explaining ++comments etc) Things like: "I think I've basically stopped using the bug system because it's too slow; it takes 10-30 seconds for a bug to load, and similar times for queries to run. So I keep work to do in a plain text file and ignore the bug system." (https://groups.google.com/d/msg/mozilla.dev.planning/DdVD2QPnJC4/ZH-BSkFkH-UJ) ...just make me sadfaces - and I hope this bug could at least alleviate some of the perceived slowness.

(In reply to Ed Morley [:edmorley UTC+0] from comment #8) > Now that we have bug 803058, please can we do this? :-) > (With blog post about it and explaining ++comments etc) > > Things like: > "I think I've basically stopped using the bug system because it's too > slow; it takes 10-30 seconds for a bug to load, and similar times > for queries to run. So I keep work to do in a plain text file and > ignore the bug system." > (https://groups.google.com/d/msg/mozilla.dev.planning/DdVD2QPnJC4/ZH-BSkFkH- > UJ) > > ...just make me sadfaces - and I hope this bug could at least alleviate some > of the perceived slowness. I don't see why we can't make this happen now as the feature is present in the current code and 4.2. glob, ok with changing the default now and blogging about it? dkl

Could we also make the not-logged-in default to not doing comment-searching too? (Given that the dev.planning thread had glandium suggest people log out for speed, so more people may be doing that now)

(In reply to Ed Morley [:edmorley UTC+0] from comment #10) > Could we also make the not-logged-in default to not doing comment-searching > too? > > (Given that the dev.planning thread had glandium suggest people log out for > speed, so more people may be doing that now) Non-logged-in users always use the site defaults for all preferences. Changing from the default requires being logged in. So this is not a problem. dkl

(In reply to David Lawrence [:dkl] from comment #9) > I don't see why we can't make this happen now as the feature is present in > the current code and 4.2. glob, ok with changing the default now and > blogging about it? yes, i'll fire off blog and dev.planning posts about this on monday, thinking of giving people one week's warning about this change (as it may impact dashboards, etc).

scheduled for the 24th. blogged, dev.planned, and yammered.

"Include comments when performing quick searches (slower)" now defaults to "Off".