Closed
Bug 687376
Opened 13 years ago
Closed 13 years ago
continue_test in test_browserhistory.js might never execute
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: espindola, Assigned: mak)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
Adding a do_check_eq(0, 1) at the start of continue_test doesn't cause the test to fail. See for example:
https://tbpl.mozilla.org/?tree=Try&rev=efe2ff0296e9
I found this while working on bug 673017 when the patch I was testing caused continue_test to execute during shutdown (which fails).
|
Assignee | |
Comment 1•13 years ago
|
||
looks like the test is missing do_test_pending and do_test_finished, good catch!
|
Reporter | |
Comment 2•13 years ago
|
||
I tried the attached patch, but then the test freezes. Hitting control-c shows that the last executed check was
.../test_browserhistory.js | [continue_test : 218] 0 == 0
|
|
Assignee | |
Comment 3•13 years ago
|
||
well, it may be the test is just broken, it needs a cleanup regardless, so I may look at it.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Well I ended up rewriting it with current conventions, this way it's also much shorter while the tested paths don't change.
|
|
Assignee | |
Updated•13 years ago
|
Attachment #561086 -
Flags: review?(dietrich)
|
||
Updated•13 years ago
|
Attachment #561086 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Flags: in-testsuite+
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•