Closed
Bug 687634
Opened 13 years ago
Closed 13 years ago
testing blackImage->CairoStatus value twice in gfxXlibNativeRenderer::Draw
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: arno, Assigned: arno)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Hi,
in gfxXlibNativeRenderer::Draw, there is:
if (blackImage->CairoStatus() == CAIRO_STATUS_SUCCESS &&
blackImage->CairoStatus() == CAIRO_STATUS_SUCCESS) {
This has been changed in attachment 461146 [details] [diff] [review].
This is probably a typo where the second blackImage should be whiteImage
|
Assignee | |
Comment 1•13 years ago
|
||
Comment on attachment 561013 [details] [diff] [review]
patch proposal
Review of attachment 561013 [details] [diff] [review]:
-----------------------------------------------------------------
Great catch!
Attachment #561013 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 3•13 years ago
|
||
This is now in my queue of things that are being sent to try then onto inbound :-)
Keywords: checkin-needed
Version: unspecified → Trunk
|
|
||
Comment 4•13 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=f07268905b26
https://hg.mozilla.org/integration/mozilla-inbound/rev/89d8b2add33f
Target Milestone: --- → mozilla9
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•