Closed Bug 687864 Opened 13 years ago Closed 13 years ago

Add offline renderer awareness for Mac OGL

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla9

People

(Reporter: BenWa, Assigned: BenWa)

References

(Depends on 1 open bug)

Details

Attachments

(3 files)

Workaround for blocker 687868 - Don't check for Layers support
(deleted), patch
Details | Diff | Splinter Review
Part 1: Add offline renderer awareness for Mac OGL in browser
(deleted), patch
jrmuizel
: review+
Details | Diff | Splinter Review
Part 2: Add offline renderer awareness for Mac OGL in plugins
(deleted), patch
jrmuizel
: review+
Details | Diff | Splinter Review
http://developer.apple.com/library/mac/#technotes/tn2229/_index.html In a nutshell we need to declare our renderers as offline renderer aware and handle renderer change notification.
Depends on: 687868
Blocks: 604135
Blocks: 568327
Blocks: 646043
Attachment #561540 - Flags: review?(jmuizelaar)
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #561541 - Flags: review?(jmuizelaar)
I don't check for renderer change notification currently. Do we need to update feature status that may differ between the two gpus?
Comment on attachment 561540 [details] [diff] [review] Part 1: Add offline renderer awareness for Mac OGL in browser The way we set double buffer is sort of scary... I also just thought about the impact that a change in max texture size could have on us.
Attachment #561540 - Flags: review?(jmuizelaar) → review+
Comment on attachment 561541 [details] [diff] [review] Part 2: Add offline renderer awareness for Mac OGL in plugins It might be worth adding a comment near where we create the PBuffer that worries about it and mentions this url:http://developer.apple.com/library/mac/#technotes/tn2229/_index.html#//apple_ref/doc/uid/DTS40008924-CH1-SECTION7
Attachment #561541 - Flags: review?(jmuizelaar) → review+
Bug 687868 is no longer required FOR RELEASE BUILDS because apple sniffs our bundle ID
No longer depends on: 687868
Keywords: checkin-needed
Depends on: 687868
The try run in comment 5 shows the same OS X64 debug M-oth orange twice in a row. Is it related? I've retriggered it again to see if it was just bad luck with a not yet filed random orange.
I don't think they are related. This change can only get properly tested with hardware with dual gpu so I don't expected we would see any regression on tinderbox. In any case I'll hold on check-in flag until this is resolved.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5c52fd250a41 https://hg.mozilla.org/mozilla-central/rev/2c5bbb176d01
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
I see this is marked fixed. What is the timeline for releasing this fix?
Target is mozilla9, that's 20-Dec-11.
Depends on: 714723
Blocks: 721285
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: