Closed
Bug 688468
Opened 13 years ago
Closed 13 years ago
Fix up nsIFrameMessageManager::sendAsyncMessage/nsISyncMessageSender::sendSyncMessage IDL signature
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #561737 -
Flags: review?(bzbarsky)
Flags: in-testsuite-
|
||
Comment 1•13 years ago
|
||
Comment on attachment 561737 [details] [diff] [review]
Patch v1
You need to rev the iids.
>+ * the Mozilla FOundation.
s/O/o/
This patch is inconsistent about whether one casts between jschar* and PRUnichar* with static_cast or reinterpret_cast. If the former works, stick with it!
>+ if (!JS_ParseJSON(ctx, reinterpret_cast<const jschar*>(nsString(aJSON).get()),
As long as you're here, PromiseFlatString(), please.
r=me with those nits.
Attachment #561737 -
Flags: review?(bzbarsky) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
|
||
Comment 3•12 years ago
|
||
(In reply to Boris Zbarsky from comment #1)
> (From update of attachment 561737 [details] [diff] [review])
> >+ if (!JS_ParseJSON(ctx, reinterpret_cast<const jschar*>(nsString(aJSON).get()),
>
> As long as you're here, PromiseFlatString(), please.
Still wrong. aJSON.BeginReading() suffices, because we don't need the string to be terminated.
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•