Closed
Bug 68879
Opened 24 years ago
Closed 24 years ago
Biff doesn't clear
Categories
(SeaMonkey :: MailNews: Message Display, defect, P2)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: scottputterman, Assigned: skasinathan)
References
(Blocks 1 open bug)
Details
(Whiteboard: [nsbeta1+]Have Fix)
Attachments
(5 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
WinNT 2001021408 IMAP
Biff should clear on the account level and the taskbar when I acknowledge it. The
ways it acknowledges it is by doing something like reading a message or doing
Get Messages. Get Messages clears biff just fine, but I'm finding that even
after I read all of my new messages in a folder, the account level biff
indicator and the taskbar indicator both stay turned on.
Reporter | ||
Comment 1•24 years ago
|
||
nominating for nsbeta1 because it makes me think I have new mail when I really
don't.
Keywords: nsbeta1
OS: Windows NT → All
QA Contact: esther → fenella
Hardware: PC → All
Reporter | ||
Comment 2•24 years ago
|
||
marking nsbeta1+ and moving to mozilla0.9
Priority: -- → P2
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9
I swear this worked a day or two before the mail/news branch merged. I think
Bhuvan fixed a leak that made this work.
Just to note: this is broken with POP3, too, so seems no to be protocol specific.
Comment 9•24 years ago
|
||
Still seeing this on 2001-04-19-08 builds. Biff arrow stays at the account level
and taskbar after all the messages are read on mac and linux for both imap and
pop accounts. However windows imap is fine but not pop account.
Sheela, even after reading all new messages in my IMAP account, biff still
doesn't clear until I do a GetMsg. Suresh can confirm this also (we looked
briefly at this problem yesterday)
Reporter | ||
Comment 11•24 years ago
|
||
Windows imap doesn't work for me either.
Comment 12•24 years ago
|
||
*** Bug 62087 has been marked as a duplicate of this bug. ***
Comment 13•24 years ago
|
||
I'm not sure, but I don't think it's networking specific.
Still not workin btw, when I do GetMsgs and then read all new - the biff
indicator is still on the account until I press GetMsgs and I don't have any
emails left to download.
*** Bug 67834 has been marked as a duplicate of this bug. ***
Comment 15•24 years ago
|
||
67834<68879
<wonder>
from: http://www.mozilla.org/quality/help/bugzilla-helper.html
> [...]
> Step 2. Search for your bug.
> [...]
is this valid only for dummy non-netscape employees?
</wonder>
Comment 16•24 years ago
|
||
When starting a new navigator window, the biff state is set right for that
window, while the others still show unread messages
Reporter | ||
Comment 17•24 years ago
|
||
suresh says he has a fix so reassigning.
Assignee: racham → suresh
Assignee | ||
Comment 18•24 years ago
|
||
Assignee | ||
Comment 19•24 years ago
|
||
Oh wait! I found a case where this breaks again :( Ignore my previous patch. New
patch on its way...
Status: NEW → ASSIGNED
Assignee | ||
Comment 20•24 years ago
|
||
Assignee | ||
Comment 21•24 years ago
|
||
Adding racham for review.
Comment 22•24 years ago
|
||
Suresh,
Things I noticed are that you may want to revisit the indentation and also
making the portion of the code you didn't really modify untouched AND optimize
the code in nsMsgFolderDataSource.cpp to use to get the folder in question and
then to execute the common code block.
bhuvan
Assignee | ||
Comment 23•24 years ago
|
||
Comment 24•24 years ago
|
||
Indentation still seems to be little off. Please take care of that.
Make sure you run some sample tests to validate the optimizations you did are
working the way they are expected to.
r=bhuvan
Comment 25•24 years ago
|
||
It would be better to replace
+ else if((changedFlags & MSG_FLAG_READ) || (changedFlags & MSG_FLAG_REPLIED)
+ || (changedFlags & MSG_FLAG_FORWARDED) || (changedFlags &
MSG_FLAG_IMAP_DELETED)
+ || (changedFlags & MSG_FLAG_NEW) || (changedFlags & MSG_FLAG_OFFLINE))
with else if (changedFlags & (MSG_FLAG_READ|MSG_FLAG_REPLIED...))
also, indentation/tabs seem messed up, especially in the second part of the patch.
Assignee | ||
Comment 26•24 years ago
|
||
Comment 27•24 years ago
|
||
Not MSG_FLAG_READ || MSG_FLAG_REPLIED || MSG_FLAG_FORWARDED
+ || MSG_FLAG_IMAP_DELETED || MSG_FLAG_NEW || MSG_FLAG_OFFLINE)
,
MSG_FLAG_READ | MSG_FLAG_REPLIED | ...
you want the bitwise Or, '|', not the logical Or, ||
Assignee | ||
Comment 28•24 years ago
|
||
Comment 29•24 years ago
|
||
sr=bienvenu.
For future reference, you don't need the extra ()'s in something like this:
if ((a | b))
if (a | b) is fine.
Reporter | ||
Updated•24 years ago
|
Whiteboard: [nsbeta1+] → [nsbeta1+]Have Fix
Assignee | ||
Comment 30•24 years ago
|
||
I checked in yesterday!
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 31•24 years ago
|
||
verified,
2001051710 win98
2001051708 mac
2001051708 linux
Status: RESOLVED → VERIFIED
Comment 32•24 years ago
|
||
*** Bug 80527 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•