Closed
Bug 689046
Opened 13 years ago
Closed 13 years ago
createPattern(zero-size canvas) should throw
Categories
(Core :: Graphics: Canvas2D, defect)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
()
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Azure already does this, regular doesn't.
Attachment #562315 -
Flags: review?(roc)
Flags: in-testsuite+
Comment on attachment 562315 [details] [diff] [review]
Patch v1
Review of attachment 562315 [details] [diff] [review]:
-----------------------------------------------------------------
Code looks good, but why not use "is" in the tests?
Assignee | ||
Comment 2•13 years ago
|
||
The test is auto-generated from the same source as the W3C test, and I'd rather keep our copy as close as possible to that, to make it easier to update (which I happen to be working on atm).
Also, is() uses == instead of ===, which I guess is fine in this case, but I wouldn't want to change that in the general case.
Attachment #562315 -
Flags: review?(roc) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Assignee | ||
Updated•13 years ago
|
Keywords: dev-doc-needed
Comment 5•13 years ago
|
||
Documentation updated:
https://developer.mozilla.org/en/DOM/CanvasRenderingContext2D#createPattern%28%29
https://developer.mozilla.org/en/Canvas_tutorial/Applying_styles_and_colors#Patterns
And mentioned on Firefox 10 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•