Closed
Bug 689124
Opened 13 years ago
Closed 13 years ago
Tweak small-dimension video control CSS
Categories
(Toolkit :: Video/Audio Controls, defect)
Toolkit
Video/Audio Controls
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: fryn, Assigned: fryn)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
A negative right margin should only be applied on the play button for the normal-size controls.
Also, AFAIK, visibility should be collapse not hidden for the scrubber for small-size controls to avoid it expanding the controls beyond the available rect.
|
Assignee | |
Comment 1•13 years ago
|
||
Note: this patch is a diff on top of the patch for bug 649490, but it doesn't have anything to do with that bug.
Attachment #562393 -
Flags: review?(dolske)
Attachment #562393 -
Flags: feedback?(jwein)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 562393 [details] [diff] [review]
patch
Jared and I discussed this, and we still need the flexible space that the scrubber provides, this patch is invalid.
Attachment #562393 -
Attachment is obsolete: true
Attachment #562393 -
Flags: review?(dolske)
Attachment #562393 -
Flags: feedback?(jwein)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Using the universal selector (*) as the right-most sub-selector of a rule is inefficient. Plus, there is duplication between the two |visibility: hidden;| rules. This patch simply combines the two rules and optimizes them.
See:
https://developer.mozilla.org/en/Writing_Efficient_CSS#Avoid_Universal_Rules
Attachment #562558 -
Flags: review?(dolske)
|
||
Updated•13 years ago
|
Attachment #562558 -
Flags: review?(dolske) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•