The new "sort" options on the view menu of the bookmarks and history windows should have mnemonics in order to make those items easier to hit with the keyboard. Bonus points if you use the same mnemonics for similar column names in both bookmarks and history, even when those items have slightly different names (bug 68959).

Blake has informed me that these menu items are actually not new.

Moving to XPApps and adding keywords.

cc alec who owns the global history window.

I like the old summary better.. it's easier to search for.

.9.9

--> andreww

approving nomination and accepting for Andrew. He's fixed a bunch o' these for improved access.

Looks like the sorting is no longer in the bookmarks view menu, but I still see it in the history view. Updating summary to reflect this.

I should have know this wouldnt be a straightforward xul change. I need to talk to Ben to figure out how the code here works: http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/content/nsTreeU tils.js#273 So that we can add a routine to add mnemonics to those lables. Adding Ben to cc:

Thanks to Ben Goodger for the idea to add accesskey attributes to the tree columns and then fetch them from the dom when needed like the labels already are. Patch ready for review.

Comment on attachment 72163 [details] [diff] [review] changes to historyTreeOverlay.dtd, historyTreeOverlay.xul, nsTreeUtils.js sr=alecf

Comment on attachment 72163 [details] [diff] [review] changes to historyTreeOverlay.dtd, historyTreeOverlay.xul, nsTreeUtils.js r=varada

Comment on attachment 72163 [details] [diff] [review] changes to historyTreeOverlay.dtd, historyTreeOverlay.xul, nsTreeUtils.js sr=ben@netscape.com

Comment on attachment 72163 [details] [diff] [review] changes to historyTreeOverlay.dtd, historyTreeOverlay.xul, nsTreeUtils.js a=asa (on behalf of drivers) for checkin to the 1.0 trunk

fix checked into trunk.

fix is in.

As far as I can tell, this is not fixed. Looking at the patch I presume the goal was to create mnemonics for the various sort options in the View menu, including Sort by(Title|Location|Last Visited|First Visited|Hostname|Referrer|Visit Count). So there should be little underlines and the appropriate letters should work. There are no underlines and none of the key commands work with a 2002032203 Win98 build. Reopening. Let me know if I've read this incorrectly

No you are right. Something is not working properly. Checking it out asap.

...history has been using outliner for quite a while now. Did this ever work?

Moving to 1.0.1.

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt. If you have any questions about this, please email adt@netscape.com. You can search for "changing adt3 bugs" to quickly find and delete these bug mails.

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt. If you have any questions about this, please email adt@netscape.com. You can search for "changing adt3 bugs" to quickly find and delete these bug mails.

Modifies nsTreeSorting.js to hook up the accesskey attribute from the <treecol>'s with the generated menuitems.

Comment on attachment 196774 [details] [diff] [review] hooks up accesskeys on generated menuitems r+sr=me but you'll need to fix the "Sorted by Last Visited" access key before you can check this in.

Fixes the conflicting accesskey. The two viable choices were 's' or 'e', so I picked the one closest to the left. Neil: If you sr, could you help me check this in? I also noted that clicking on these headers actually don't work. It fails with "JavaScript error: chrome://global/content/nsTreeSorting.js, line 67: column.parentNode has no properties". But I guess that's another bug.

Comment on attachment 197387 [details] [diff] [review] hooks up accesskeys on generated menuitems v0.2 I decided on Last _Visited and Visit _Count.

Fix checked in. (In reply to comment #25) > But I guess that's another bug. Bug 257985 to be precise.

Comment on attachment 197387 [details] [diff] [review] hooks up accesskeys on generated menuitems v0.2 (for the XPFE part of this patch only, of course)

Seamonkey-only portion of fix checked in to the 1.8 branch.