Also, it feels like the box animates while it shrinks down to that pixel size, aren't the animations disabled while locked?

I found another situation where the highlighter and/or the infobar are still visible when they should not (selecting a non-highlightable node after a highlightable node).

I think the infobar should be move to the top/left corner, bot be hidden.

- hide the highlighter borders if node not highlitable - move the infobar to the top-left corner if node not highlitable

Comment on attachment 566151 [details] [diff] [review] patch v1 // node is not set or node is not highlightable, bail - if (!this.node || !this.isNodeHighlightable(this.node)) { - return; - } + if (this.node && this.isNodeHighlightable(this.node)) { I think I'd prefer to bail out early rather than nest the remainder of this method in an if { } block. r+ with that reverted.

Well, actually, we don't want to bail out here. We want to execute: > this.highlightRectangle(rect); > this.moveInfobar(); (after the if block). I think here I should only remove the comment.

(In reply to Paul Rouget [:paul] from comment #6) > Well, actually, we don't want to bail out here. We want to execute: > > > this.highlightRectangle(rect); > > this.moveInfobar(); > > (after the if block). > > I think here I should only remove the comment. OK, fair enough. One thing I would like to see fixed though is the while(true) block. Can we replace that with something like: while (!(frameWin.parent === frameWin || !frameWin.frameElement)) { ? or do { ... } while() ?

(In reply to Rob Campbell [:rc] (robcee) from comment #7) > (In reply to Paul Rouget [:paul] from comment #6) > > Well, actually, we don't want to bail out here. We want to execute: > > > > > this.highlightRectangle(rect); > > > this.moveInfobar(); > > > > (after the if block). > > > > I think here I should only remove the comment. > > OK, fair enough. > > One thing I would like to see fixed though is the while(true) block. Can we > replace that with something like: > > while (!(frameWin.parent === frameWin || !frameWin.frameElement)) { > > ? > > or do { ... } while() ? I don't see how I could do that.

ok, after another look, it looks like it'll be a pain to move that around, so don't worry about it.

removed the comfusing comment