Closed Bug 690857 Opened 13 years ago Closed 13 years ago

Windows 7 Taskbar Previews broken on Nightly

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla10

People

(Reporter: murph.0912, Assigned: rain1)

References

Details

(Keywords: regression, Whiteboard: [inbound])

Attachments

(3 files)

Image of Taskbar Preview Issue
(deleted), image/png
Details
Case with one showing favicon (which was in an individual window) and the missed thumbnail-
(deleted), image/png
Details
patch v1
(deleted), patch
mwu
: review+
Details | Diff | Splinter Review
Attached image Image of Taskbar Preview Issue (deleted) —
Tab content fails to display in taskbar previews STR: 1. In new profile, check option to display previews in Taskbar. 2. Hover mouse over taskbar to display of all tabs open in browser. Expected: Preview of content of each tab will be shown. Actual: See Image attached.
Keywords: regression
Regression range based on Nightly nightly buids: Changeset cb4b93331e4f: OK Changeset b5b082d183d0: Not OK
It's similar for me, but my tab previews are the various tabs' favicons.
In addition it also affects if you have other Firefox windows open. Only if the option is enabled.
Yes, I can reproduce. Looking into it.
I backed out bug 515907 and the problem still persists, plus that bug doesn't really touch the part of the code that generates previews, so I really doubt it's that.
Summary: Bug 515907 Breaks Win7 Taskbar Previews on Nightly → Windows 7 Taskbar Previews broken on Nightly
Component: General → Widget: Win32
Product: Firefox → Core
QA Contact: general → win32
mwu, could your PRBool to bool change have caused this? See <https://hg.mozilla.org/mozilla-central/diff/e7854b4d29ba/widget/src/windows/TaskbarTabPreview.cpp>.
Yep, I'm pretty sure that's the reason.
Depends on: 675553
No longer depends on: 515907
Attached patch patch v1 (deleted) — — Splinter Review
Yep, fallout. We didn't catch this because we were assuming (and not type checking) that PRBool = BOOL.
Assignee: nobody → sagarwal
Status: NEW → ASSIGNED
Attachment #563827 - Flags: review?(mwu)
Attachment #563827 - Flags: review?(mwu) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/746002692d93
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Ugh, sorry, I always slip up with marking inbound patches as fixed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [inbound]
Target Milestone: mozilla10 → ---
Blocks: 675553
No longer depends on: 675553
https://hg.mozilla.org/mozilla-central/rev/746002692d93
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
I just grabbed the Nightly hourly (C-set ID 164fd1bbd06f) containing the needed patch and can confirm that Win7 Taskbar Previews have been fixed. Thanks for the fix. Sorry for the initial misdirection. Just think of it as a little test. ;-)
No worries: my patch was the obvious one to blame.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: