Closed Bug 691100 Opened 13 years ago Closed 13 years ago

Read It Later (and apparently Omnibar) cause location bar to be taller than usual

Categories

(Firefox :: Extension Compatibility, defect)

Product:
Firefox
Component:
Extension Compatibility
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox7 --- unaffected
firefox8 --- unaffected
firefox9 --- affected
firefox10 --- affected

People

(Reporter: joe, Unassigned)

References

Details

Ever since bug 684450 landed, Read It Later causes my location bar to be bigger than it should be. Stephen Horlander says in bug 684450 comment 22: > It looks like extensions that add items to the #urlbar-icon hbox are > affected by this. So far I have only found Omnibar and Read It Later. > > Both of them are adding their own padding, which should be fine, but for > some reason both of them are adding the .urlbar-icons class to the > #urlbar-icon hbox. This should be fixed (or ignored and documented).
> > both of them are adding the .urlbar-icons class to the > > #urlbar-icon hbox. This is their bug. Afaik omnibar is already fixed.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
Has it been documented? What were they doing wrong?
They were arbitrarily and needlessly setting a CSS class on a node where it makes no sense. Since it never made sense, we don't need to document this.
Component: Location Bar → Extension Compatibility
QA Contact: location.bar → extension.compatibility
You need to log in before you can comment on or make changes to this bug.