Closed
Bug 691389
Opened 13 years ago
Closed 13 years ago
Error: win is null when performing drag&drop of a XPI file to Add-ons Manager tab.
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: alice0775, Assigned: Unfocused)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/rev/90575e23ea93
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111003 Firefox/10.0a1 ID:20111003030859
Error: win is null when I performed drag & drop of a xpi file to Add-ons tab.
Reproducible: Always
Steps to Reproduce:
1. Start Firefox with clean profile
2. Open Error console(Ctrl+Shift+J)
3. Open Add-ons(Ctrl+Shift+A)
4. Drag and drop a xpi file to Add-ons tab.
5. Software Instalation dialog pops up
Actual Results:
Error: win is null
Source File: chrome://browser/content/browser.js
Line: 4099
observe: function (aSubject, aTopic, aData)
{
var brandBundle = document.getElementById("bundle_brand");
var installInfo = aSubject.QueryInterface(Components.interfaces.amIWebInstallInfo);
var win = installInfo.originatingWindow;
>> var shell = win.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
Reporter | ||
Updated•13 years ago
|
Hardware: x86_64 → x86
Reporter | ||
Comment 1•13 years ago
|
||
Regression window(cached m-c hourly),
Works:
http://hg.mozilla.org/mozilla-central/rev/10927265c555
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110802 Firefox/8.0a1 ID:20110802025715
Fails:
http://hg.mozilla.org/mozilla-central/rev/a8bbb17fd043
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110802 Firefox/8.0a1 ID:20110802052514
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=10927265c555&tochange=a8bbb17fd043
Keywords: regression
Assignee | ||
Comment 2•13 years ago
|
||
Fallout from bug 670023. Basically the same cause as bug 677646 had.
Blocks: 670023
Comment 3•13 years ago
|
||
Alice, does it mean the installation doesn't work at all via D&D into the add-ons manager now?
Version: Trunk → 8 Branch
Reporter | ||
Comment 4•13 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #3)
> Alice, does it mean the installation doesn't work at all via D&D into the
> add-ons manager now?
Installation is successfully performed.
However, the following problem exists.
a. Compatible issue arrow panel does not appear if incompatible version xpi is dropped.
b. Installed Successfully arrow panel does not appear when Install Now button clicked in Software Installation dialog for restartless addon.
c. Restart Now arrow panel does not appear when Install Now button clicked in Software Installation dialog for olds tyle addon.
Comment 5•13 years ago
|
||
Thanks Alice. Sounds we should track it for Firefox 8 and 9.
tracking-firefox8:
--- → ?
tracking-firefox9:
--- → ?
Updated•13 years ago
|
Assignee: nobody → bmcbride
Assignee | ||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•13 years ago
|
OS: Windows 7 → All
Hardware: x86 → All
Summary: Error: win is null when I performed drag & drop of a xpi file to Add-ons tab. → Error: win is null when performing drag&drop of a XPI file to Add-ons Manager tab.
---------------------------------[ Triage Comment ]---------------------------------
We need to track this for Firefox 8 to see how bad an issue it is and if it needs to be fixed before ship.
CCing Asa and Boriss as well.
Comment 7•13 years ago
|
||
Drag and drop of an XPI is an edge case I don't think we should worry too much about. The crazy overwhelming majority of our add-on users get add-ons by other means than downloading XPIs, locating them on their hard drives, and dragging them on to the Add-ons manager in Firefox.
status-firefox8:
--- → wontfix
Updated•13 years ago
|
Assignee | ||
Comment 8•13 years ago
|
||
Attachment #584895 -
Flags: review?(dtownsend)
Updated•13 years ago
|
Attachment #584895 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 9•13 years ago
|
||
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla12
Comment 10•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Comment 12•13 years ago
|
||
Oh update. The install window did pop but it popped under. So i didnt see it. So I saw a bunch of "Software Installtion" pop ups in the task bar.
Assignee | ||
Comment 13•13 years ago
|
||
Can you file a separate bug for that? Thanks.
Comment 14•13 years ago
|
||
ok sure :)
Comment 15•13 years ago
|
||
I'm very new to writing extensions and am getting this precisely this error. But I'm such an blithering fool that I cannot find on this site an explanation of how to use the attachments to repair the bug. Are these files I need add somewhere? Please reply as if I'm a complete idiot.
Comment 16•13 years ago
|
||
(In reply to craig.nicholas from comment #15)
> I'm very new to writing extensions and am getting this precisely this error.
> But I'm such an blithering fool that I cannot find on this site an
> explanation of how to use the attachments to repair the bug. Are these files
> I need add somewhere? Please reply as if I'm a complete idiot.
This bug should be fixed in Firefox 12, due for release sometime this week. Probably easiest to just wait for that.
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•