Closed Bug 691389 Opened 13 years ago Closed 13 years ago

Error: win is null when performing drag&drop of a XPI file to Add-ons Manager tab.

Categories

(Toolkit :: Add-ons Manager, defect)

8 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12
Tracking Status
firefox8 + wontfix
firefox9 - ---

People

(Reporter: alice0775, Assigned: Unfocused)

References

Details

(Keywords: regression)

Attachments

(1 file)

http://hg.mozilla.org/mozilla-central/rev/90575e23ea93 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111003 Firefox/10.0a1 ID:20111003030859 Error: win is null when I performed drag & drop of a xpi file to Add-ons tab. Reproducible: Always Steps to Reproduce: 1. Start Firefox with clean profile 2. Open Error console(Ctrl+Shift+J) 3. Open Add-ons(Ctrl+Shift+A) 4. Drag and drop a xpi file to Add-ons tab. 5. Software Instalation dialog pops up Actual Results: Error: win is null Source File: chrome://browser/content/browser.js Line: 4099 observe: function (aSubject, aTopic, aData) { var brandBundle = document.getElementById("bundle_brand"); var installInfo = aSubject.QueryInterface(Components.interfaces.amIWebInstallInfo); var win = installInfo.originatingWindow; >> var shell = win.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
Hardware: x86_64 → x86
Regression window(cached m-c hourly), Works: http://hg.mozilla.org/mozilla-central/rev/10927265c555 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110802 Firefox/8.0a1 ID:20110802025715 Fails: http://hg.mozilla.org/mozilla-central/rev/a8bbb17fd043 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110802 Firefox/8.0a1 ID:20110802052514 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=10927265c555&tochange=a8bbb17fd043
Keywords: regression
Fallout from bug 670023. Basically the same cause as bug 677646 had.
Blocks: 670023
Alice, does it mean the installation doesn't work at all via D&D into the add-ons manager now?
Version: Trunk → 8 Branch
(In reply to Henrik Skupin (:whimboo) from comment #3) > Alice, does it mean the installation doesn't work at all via D&D into the > add-ons manager now? Installation is successfully performed. However, the following problem exists. a. Compatible issue arrow panel does not appear if incompatible version xpi is dropped. b. Installed Successfully arrow panel does not appear when Install Now button clicked in Software Installation dialog for restartless addon. c. Restart Now arrow panel does not appear when Install Now button clicked in Software Installation dialog for olds tyle addon.
Thanks Alice. Sounds we should track it for Firefox 8 and 9.
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
OS: Windows 7 → All
Hardware: x86 → All
Summary: Error: win is null when I performed drag & drop of a xpi file to Add-ons tab. → Error: win is null when performing drag&drop of a XPI file to Add-ons Manager tab.
---------------------------------[ Triage Comment ]--------------------------------- We need to track this for Firefox 8 to see how bad an issue it is and if it needs to be fixed before ship. CCing Asa and Boriss as well.
Drag and drop of an XPI is an edge case I don't think we should worry too much about. The crazy overwhelming majority of our add-on users get add-ons by other means than downloading XPIs, locating them on their hard drives, and dragging them on to the Add-ons manager in Firefox.
Attached patch Patch v1 (deleted) — Splinter Review
Attachment #584895 - Flags: review?(dtownsend)
Attachment #584895 - Flags: review?(dtownsend) → review+
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla12
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Oh update. The install window did pop but it popped under. So i didnt see it. So I saw a bunch of "Software Installtion" pop ups in the task bar.
Can you file a separate bug for that? Thanks.
ok sure :)
I'm very new to writing extensions and am getting this precisely this error. But I'm such an blithering fool that I cannot find on this site an explanation of how to use the attachments to repair the bug. Are these files I need add somewhere? Please reply as if I'm a complete idiot.
(In reply to craig.nicholas from comment #15) > I'm very new to writing extensions and am getting this precisely this error. > But I'm such an blithering fool that I cannot find on this site an > explanation of how to use the attachments to repair the bug. Are these files > I need add somewhere? Please reply as if I'm a complete idiot. This bug should be fixed in Firefox 12, due for release sometime this week. Probably easiest to just wait for that.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: