Closed Bug 69146 Opened 24 years ago Closed 24 years ago

Scrollbars sometimes paint incorrectly with new viewmanager

Categories

(Core :: Web Painting, defect)

x86
Windows NT
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: kmcclusk, Assigned: roc)

References

()

Details

Attachments

(2 files)

I have noticed that sites which have banner ads will cause the vertical scrollbar to be rendered with rectangle white area at the intersection of the banner ad and the vertical scrollbar. You may need to make your window narrower than the banner add to see the effect. The white areas do not show with the ViewManager2. I have also noticed it on www.warnerbros.com
I found the problem. I optimize so that we don't draw content that's covered by an overlapping widget. But sometimes the widget doesn't cover its entire bounds, e.g. when it's enclosed in another widget that clips it. Patch forthcoming; I'd appreciate review/super review.
Status: NEW → ASSIGNED
Robert: could you attach a fresh patch? I tried your patch with a fresh pull of the view module and it failed when I applied it. Thanks.
Robert, can you remvove the tabs from the patch before you apply it? Spaces are nicer... The change looks fine to me, but I do have a question: what is the difference between getter_AddRefs and dont_AddRef? You use them both and I'm not familiar with dont_AddRef, but it seems like it is the same as getter_AddRefs.
I think you're right. I copied the code from somewhere else. I'll change it to getter_AddRefs. The top of the file says "indent-tabs-mode: true". That makes emacs put in tabs. Ugh.
patch looks good. r=kmcclusk@netscape.com
sr=attinasi, excellent work, Robert.
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Marking verified fixed in the March 01 build.
Status: RESOLVED → VERIFIED
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: