Closed
Bug 69146
Opened 24 years ago
Closed 24 years ago
Scrollbars sometimes paint incorrectly with new viewmanager
Categories
(Core :: Web Painting, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: kmcclusk, Assigned: roc)
References
()
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
I have noticed that sites which have banner ads will cause the vertical
scrollbar to be rendered with rectangle white area at the intersection of the
banner ad and the vertical scrollbar. You may need to make your window narrower
than the banner add to see the effect.
The white areas do not show with the ViewManager2.
I have also noticed it on www.warnerbros.com
Assignee | ||
Comment 1•24 years ago
|
||
I found the problem. I optimize so that we don't draw content that's covered by
an overlapping widget. But sometimes the widget doesn't cover its entire bounds,
e.g. when it's enclosed in another widget that clips it. Patch forthcoming; I'd
appreciate review/super review.
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•24 years ago
|
||
Reporter | ||
Comment 3•24 years ago
|
||
Robert: could you attach a fresh patch? I tried your patch with a fresh pull of
the view module and it failed when I applied it. Thanks.
Assignee | ||
Comment 4•24 years ago
|
||
Comment 5•24 years ago
|
||
Robert, can you remvove the tabs from the patch before you apply it? Spaces are
nicer... The change looks fine to me, but I do have a question: what is the
difference between getter_AddRefs and dont_AddRef? You use them both and I'm not
familiar with dont_AddRef, but it seems like it is the same as getter_AddRefs.
Assignee | ||
Comment 6•24 years ago
|
||
I think you're right. I copied the code from somewhere else. I'll change it to
getter_AddRefs.
The top of the file says "indent-tabs-mode: true". That makes emacs put in tabs.
Ugh.
Reporter | ||
Comment 7•24 years ago
|
||
patch looks good.
r=kmcclusk@netscape.com
Assignee | ||
Comment 8•24 years ago
|
||
Great! Marc?
Comment 9•24 years ago
|
||
sr=attinasi, excellent work, Robert.
Assignee | ||
Comment 10•24 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Layout: View Rendering → Layout: Web Painting
You need to log in
before you can comment on or make changes to this bug.
Description
•