The search box is 2px shorter than the toolbar buttons under Aero.

I've changed the min-height from 22px to 24px and gave a top and bottom margin of 1px instead of 2px to avoid a growing of the toolbar. I made the same change to the Quick Filter search box to have the same height of the search boxes.

Comment on attachment 564644 [details] [diff] [review] Make the min-height 24px The padding for filters feels a bit too narrow now.

Here is mockups with padding 1px, 2px and 3px. I'm currently leaning towards 3px padding, as that would fit the smaller icons in this bar (it almost aligns with the top and bottom of the pin) and show the difference between the search bars a bit more. This is also the height of the Find bar search box in Firefox.

With this patch I change only the Global search box. The default margin for the QFB search box is 2px and the actual height of this box is 23px (uneven top- and bottom-padding in toolkit). Add 1px on top and bottom would make the QFBar 2px taller.

Comment on attachment 565202 [details] [diff] [review] Make the min-height 24px v2 As discussed on IRC, skipping the QFB part of this patch as the sizing of it proved to be slightly tricky. Might happen as another bug. This looks good ui and code-wise, good to go!

Checked in: http://hg.mozilla.org/comm-central/rev/f9887fb58929