Closed
Bug 692406
Opened 13 years ago
Closed 13 years ago
Add a hidden pref to disable the script debugger UI
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: past, Assigned: vporof)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
Until the debugger is ready to ship, we should hide it under a hidden pref (devtools.debugger.enabled) from the moment we merge with m-c. This toggle should default to false until it is decided that the debugger is ready for broader testing.
|
Reporter | |
Updated•13 years ago
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → vporof
|
|
Reporter | |
Updated•13 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #572832 -
Flags: review?(past)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #572832 -
Flags: feedback?(dcamp)
|
|
Reporter | |
Comment 2•13 years ago
|
||
Looks good, but I'll wait for the modularization patch to apply properly first, so I can test this.
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #572832 -
Attachment is obsolete: true
Attachment #572832 -
Flags: review?(past)
Attachment #572832 -
Flags: feedback?(dcamp)
Attachment #573326 -
Flags: review?(past)
|
|
Reporter | |
Comment 4•13 years ago
|
||
Comment on attachment 573326 [details] [diff] [review]
v2
Review of attachment 573326 [details] [diff] [review]:
-----------------------------------------------------------------
Works as advertised!
Attachment #573326 -
Flags: review?(past) → review+
|
|
Reporter | |
Comment 5•13 years ago
|
||
I missed that you have kept a default of true, which was not what we intended to do, but now that I think of it, we may want to have people try it on nightlies and give us feedback. Dave what do you think?
|
|
Reporter | |
Comment 6•13 years ago
|
||
(In reply to Panos Astithas [:past] from comment #5)
> I missed that you have kept a default of true, which was not what we
> intended to do, but now that I think of it, we may want to have people try
> it on nightlies and give us feedback. Dave what do you think?
After the recent highlighter incident, it seems prudent to stick to disabled by default, so I did that.
Summary: Add a hidden pref do disable the script debugger UI → Add a hidden pref to disable the script debugger UI
|
|
Assignee | |
Comment 7•13 years ago
|
||
Agreed.
|
|
Reporter | |
Comment 8•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•