Closed
Bug 693645
Opened 13 years ago
Closed 13 years ago
output firstTimestamp in the ts logs
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
it would be really good to know the total runtime a talos tests takes. This is important as tests like ts and tshutdown can have different bits of code running in each part.
In order to not change a lot, I am adding a __startFirstTimestamp after the __startSecondTimestamp. This will be a bit confusing, but in the scenario of ts, here is what we would see:
1) __startReport314__endReport
2) __startTimestamp123456789__endTimestamp
3) __startSecondTimestamp123456789__endSecondTimestamp
0) __startFirstTimestamp123456789__endSecondTimestamp
note that 0 is at the end of this list (for compatibility reasons). If you calculate 3-0, you will get the total runtime.
Assignee | ||
Comment 1•13 years ago
|
||
need to test in staging before asking releng to deploy.
Assignee | ||
Comment 2•13 years ago
|
||
all green in staging, please review so we can get the ball rolling :)
Comment 3•13 years ago
|
||
Comment on attachment 566243 [details] [diff] [review]
output a firstTimestamp in talos to measure truntime (1.0)
As discussed on irc, the concept is fine, but let's give these variables more descriptive names (both in the code and in our output) and put them in chronological order:
startFirstTimestamp -> beforeLaunchTimestamp
startSecondTimestamp -> afterTerminationTimestamp
Assignee | ||
Comment 4•13 years ago
|
||
looks good locally, running on talos staging.
Attachment #566243 -
Attachment is obsolete: true
Attachment #566243 -
Flags: review?(wlachance)
Attachment #566835 -
Flags: review?(wlachance)
Assignee | ||
Comment 5•13 years ago
|
||
forgot a couple updates for the tp regex.
Attachment #566835 -
Attachment is obsolete: true
Attachment #566835 -
Flags: review?(wlachance)
Attachment #566847 -
Flags: review?(wlachance)
Comment 6•13 years ago
|
||
Comment on attachment 566847 [details] [diff] [review]
output a firstTimestamp in talos to measure truntime (2.1)
As I said above I'd prefer if the internal variable names/functions (getFirstTime, etc.) were renamed to be more descriptive as well, but I'd say this can go in as is if it works in the testing environment. We can always clean that up later as part of another patch to bcontroller.py.
Attachment #566847 -
Flags: review+
Comment 7•13 years ago
|
||
Comment on attachment 566847 [details] [diff] [review]
output a firstTimestamp in talos to measure truntime (2.1)
Review of attachment 566847 [details] [diff] [review]:
-----------------------------------------------------------------
As I said above I'd prefer if the internal variable names/functions (getFirstTime, etc.) were renamed to be more descriptive as well, but I'd say this can go in as is if it works in the testing environment. We can always clean that up later as part of another patch to bcontroller.py.
Assignee | ||
Updated•13 years ago
|
Attachment #566847 -
Flags: review?(wlachance)
Assignee | ||
Comment 8•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 9•13 years ago
|
||
Thanks everyone for jumping in to help make this test better so quickly.
Assignee | ||
Comment 10•13 years ago
|
||
we still need to get this rolled out in production. I filed a bug 694579 for deploying talos
You need to log in
before you can comment on or make changes to this bug.
Description
•