Closed Bug 694690 Opened 13 years ago Closed 13 years ago

Youtube HTML5 Video's Fullscreen Button does not work.

Categories

(Core :: General, defect)

9 Branch
x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox9 - ---
firefox10 - ---

People

(Reporter: alice0775, Assigned: cpearce)

References

()

Details

(Keywords: regression)

Build Identifier: http://hg.mozilla.org/releases/mozilla-aurora/rev/b2f3b19ebe42 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a2) Gecko/20111014 Firefox/9.0a2 ID:20111014042012 and http://hg.mozilla.org/mozilla-central/rev/9545b88eed82 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111014 Firefox/10.0a1 ID:20111014030948 Youtube HTML5 Video's Fullscreen Button does not work. Reproducible: Always Steps to Reproduce: 1. Start Firefox with clean profile 2 Open URL ( http://www.youtube.com/watch?v=BRG5VNNUq_E&hd=1&html5=1 ) 3. Click Youtube HTML5 Video's Fullscreen Button Actual Results: HTML5 Video stay in normal size. Expected Results: HTML5 Video should be resized. Regression window(m-c) Works: http://hg.mozilla.org/mozilla-central/rev/2bb8c0b664cf Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a1) Gecko/20110905 Firefox/9.0a1 ID:20110905030839 Fails: http://hg.mozilla.org/mozilla-central/rev/fc78ee766770 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a1) Gecko/20110905 Firefox/9.0a1 ID:20110905050036 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2bb8c0b664cf&tochange=fc78ee766770 Regression window(m-i) Works: http://hg.mozilla.org/integration/mozilla-inbound/rev/81ebc148aad3 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a1) Gecko/20110904 Firefox/9.0a1 ID:20110904121620 Fails: http://hg.mozilla.org/integration/mozilla-inbound/rev/d7cd9750988a Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a1) Gecko/20110904 Firefox/9.0a1 ID:20110904134605 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=81ebc148aad3&tochange=d7cd9750988a Triggered by: Bug 545812 - API for controlling fullscreen from content
Keywords: regression
Version: 9 Branch → Trunk
YouTube have a fix in the pipe for this.
YouTube's fix has been deployed.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
Hi guys. I was able to reproduce this issue on: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0 beta 1 Mozilla/5.0 (Windows NT 6.0; rv:9.0) Gecko/20100101 Firefox/9.0 beta 1 Mozilla/5.0 (X11; Linux i686; rv:9.0) Gecko/20100101 Firefox/9.0 beta 1 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20100101 Firefox/9.0 beta 1 The html5 video doesn't play in full screen. http://www.youtube.com/watch?v=Q-73zYoUsd4
Reproducible also on Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0
I can reproduce on http://hg.mozilla.org/releases/mozilla-beta/rev/31302afe89b3 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20100101 Firefox/9.0 ID:20111109112850 And got a same regression window as comment#0. FYI, Aurora10.0a2 and Nightly11.0a1 works well.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Version: Trunk → 9 Branch
Depends on: 689058
Workaround: Set full-screen-api.enabled to true.
Is there any reason why the full screen api is disabled by default on beta?
It was only partially implemented when we cut Beta, and we want to give it time to bake on Aurora.
Based on the recent comments I think this can be resolved WORKSFORME now if this works in Aurora 10.0a2 and verified on Beta 10.0b1. Any objections?
Agreed.
Status: REOPENED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → WORKSFORME
Well, the full screen button works on beta only if full screen api is enabled.
@JK in comment 9 I said 10.0b1. When 10.0a2 (where this is enabled) is merged into Beta it becomes 10.0b1. Does comment 10 refer to 9.0 Beta or do you mean it still has to be enabled when 10.0a2 merges into 10.0b1, because that doesn't make sense to me.
So there already is a Fx10 beta build available? I thought Beta 10.0b1 was a typo and you meant Fx9 beta.
Depends on: 703881
No longer depends on: 703881
Filed: Bug 703881 - Enable Fullscreen API by default on 9 branch
Anyways, according to the version field, this is a 9 Branch bug. It does not work on 9 branch with default settings, so this should not be marked as WORKSFORME, unless the version field is changed to a working version.
(In reply to JK from comment #15) Sorry, JK, but you don't seem to be understanding the current release model. This is a bug which was found in but not limited to Firefox 9. The version field is quite often used as an indication of the earliest version of Firefox affected; seldom is it an accurate marker of where a bug will be fixed. This issue is resolved on Firefox 10 (currently Aurora). The fix will ride along with Firefox 10 all the way through to release. It will not be ported to other branches for earlier release. Use a Firefox 10 build and you will see this, hence WORKSFORME. Hopefully this explanation is sufficient.
So basically, the full screen button is/will be defective in Firefox 9. This bug should be tagged to be added to the release notes then.
(In reply to JK from comment #17) > So basically, the full screen button is/will be defective in Firefox 9. This > bug should be tagged to be added to the release notes then. Relnote nomination has been escalated.
Youtube should not be showing the fullscreen button when fullscreen is disabled (as it is in Firefox 9). We specifically added API to enable them to do that.
This is not a bug in Firefox, this is a bug in YouTube's HTML5 player. YouTube is acting as if an API which is disabled in Firefox 9 is enabled. We added an API which enables websites like YouTube to determine whether the full-screen API is enabled (document.mozFullScreenEnabled) but that's in Firefox 10, it is not available in Firefox 9. However websites can test to see if document.mozFullScreenEnabled is defined and if not can just assume that the full-screen API is not enabled by default in that build. YouTube should be checking whether document.mozFullScreenEnabled is defined in their trial HTML5 player. I can only assume they are not. So I repeat, this is not a bug in Firefox, this is a bug in YouTube's HTML5 player.
(In reply to Chris Pearce (:cpearce) (Mozilla Corporation) from comment #20) > So I repeat, this is not a bug in Firefox, this is a bug in YouTube's HTML5 > player. Is it still not worth relnoting, since most users will not see it this way?
Most users won't see it. The HTML5 trial player is opt-in.
(In reply to Chris Pearce (:cpearce) (Mozilla Corporation) from comment #20) > This is not a bug in Firefox, this is a bug in YouTube's HTML5 player. > YouTube is acting as if an API which is disabled in Firefox 9 is enabled. > > We added an API which enables websites like YouTube to determine whether the > full-screen API is enabled (document.mozFullScreenEnabled) but that's in > Firefox 10, it is not available in Firefox 9. However websites can test to > see if document.mozFullScreenEnabled is defined and if not can just assume > that the full-screen API is not enabled by default in that build. > > YouTube should be checking whether document.mozFullScreenEnabled is defined > in their trial HTML5 player. I can only assume they are not. > > So I repeat, this is not a bug in Firefox, this is a bug in YouTube's HTML5 > player. Hi Chris - you commented earlier that "YouTube have a fix in the pipe for this." Is there a bug filed with them or have we been in touch? Perhaps we can get them to fix this before releasing FF9, in which case we wouldn't need to relnote.
Just to clarify, who owns the relationship with YouTube and this special case? I think it's a good idea for us to have an idea of what the status is on their fix to this issue.
I have emailed my contacts at YouTube about this issue.
The issue is still reproducing for me on: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:9.0) Gecko/20100101 Firefox/9.0 beta 3 See comment3 for details.
We received an update from YouTube, "So the issue is even though the flag is set to false, mozRequestFullScreen is still present as a property of a HTMLElement. Fix will be out with our push next week."
YouTube has rolled out their fix for Firefox 9.
You need to log in before you can comment on or make changes to this bug.