Closed
Bug 696433
Opened 13 years ago
Closed 13 years ago
Improve link rel scanning for favicons
Categories
(Firefox for Android Graveyard :: General, enhancement, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gcp, Assigned: mfinkle)
Details
Attachments
(1 file)
(deleted),
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
rel.indexOf("icon") is not a very good test. It will match for <link rel="rubicon"> for instance.
There's a proper algorithm described here:http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#rel-icon
We can also support apple-touch-icon like we did at http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/browser-ui.js#1027
Reporter | ||
Updated•13 years ago
|
Severity: normal → enhancement
Priority: -- → P4
Updated•13 years ago
|
Assignee: nobody → lucasr.at.mozilla
Assignee | ||
Updated•13 years ago
|
Summary: Improve handling for favicons → Improve link rel scanning for favicons
Assignee | ||
Comment 1•13 years ago
|
||
This patch takes some code from desktop and sanitizes the link rel string a bit _before_ sending it to Java. Mainly because doing the same code in Java sucks!
Assignee: lucasr.at.mozilla → mark.finkle
Attachment #579958 -
Flags: review?(mbrubeck)
Updated•13 years ago
|
Attachment #579958 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Comment 3•13 years ago
|
||
Galaxy SII (Android 2.3.4)
20111208060054
http://hg.mozilla.org/integration/mozilla-inbound/rev/b0f8871174a5
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Aaron Train [:aaronmt] from comment #3)
> Galaxy SII (Android 2.3.4)
> 20111208060054
> http://hg.mozilla.org/integration/mozilla-inbound/rev/b0f8871174a5
Mis-fire. This is the wrong cset and the code is not on m-c yet :)
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•13 years ago
|
Status: REOPENED → NEW
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•