Closed
Bug 697265
Opened 13 years ago
Closed 13 years ago
Support clipboard operations in edit fields
Categories
(Firefox for Android Graveyard :: General, defect, P3)
Tracking
(firefox11 verified, fennec11+)
VERIFIED
FIXED
People
(Reporter: alexp, Assigned: mfinkle)
References
Details
(Whiteboard: [QA+])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
Need to add a context menu with Copy/Paste/Select All commands.
|
||
Updated•13 years ago
|
Assignee: nobody → wjohnston
Priority: -- → P3
|
||
Comment 2•13 years ago
|
||
WIP adds Copy, Paste, Select All and Copy All.
|
Assignee | |
Comment 4•13 years ago
|
||
Wes' patch looked OK to me. I tweaked it a bit:
* Added strings
* Moved the "Select Input Method" to the ClipboardHelper and made sure it would appear at the bottom of the context menu
Seems to work ok for me.
Assignee: wjohnston → mark.finkle
Attachment #580435 -
Attachment is obsolete: true
Attachment #581346 -
Flags: review?(mbrubeck)
|
||
Comment 5•13 years ago
|
||
Comment on attachment 581346 [details] [diff] [review]
patch
>+ matches: function(aElement) {
>+ if (NativeWindow.contextmenus.textContext.matches(aElement)) {
>+ let flavors = ["text/unicode"];
>+ return ClipboardHelper.clipboard.hasDataMatchingFlavors(flavors, flavors.length, Ci.nsIClipboard.kGlobalClipboard);
>+ }
>+ }
Please add an explicit "return false" for the case where the "if" expression is false.
Attachment #581346 -
Flags: review?(mbrubeck) → review+
|
|
||
Comment 6•13 years ago
|
||
Thanks mark!
|
|
Assignee | |
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Flags: in-litmus?(fennec)
Whiteboard: [QA+]
|
||
Updated•13 years ago
|
tracking-fennec: --- → 11+
|
|
||
Updated•13 years ago
|
status-firefox11:
--- → fixed
|
||
Comment 8•13 years ago
|
||
Existent testcases:
- https://litmus.mozilla.org/show_test.cgi?id=33768 for test run 11 and
- https://litmus.mozilla.org/show_test.cgi?id=43066 for test run 12
Flags: in-litmus?(fennec) → in-litmus+
|
||
Comment 9•13 years ago
|
||
Verified on:
Nightly 12.0a1 (2012-01-16) HTC Desire Z
Aurora 11.0a2 (2012-01-15) HTC Desire Z
Context menu with Copy/Paste/Select All/Select Input Method commands is displayed in edit fields.
Status: RESOLVED → VERIFIED
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•