Closed
Bug 697560
Opened 13 years ago
Closed 13 years ago
WebGL Conformance fails on 'read-pixels-test'
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
Attachments
(1 file, 4 obsolete files)
|
(deleted),
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
We currently do not generate errors properly in accordance to spec for gl.readPixels, causing us to fail conformance test 'read-pixels-test'.
|
Assignee | |
Comment 1•13 years ago
|
||
This fixes the argument checking for readPixels to more closely follow spec.
Attachment #569787 -
Flags: review?(bjacob)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Updates the failed test lists for win/mac/lin.
Attachment #569788 -
Flags: review?(bjacob)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Matching try: https://tbpl.mozilla.org/?tree=Try&rev=e2772af21681
|
|
Assignee | |
Comment 4•13 years ago
|
||
Unbitrotting.
Attachment #569787 -
Attachment is obsolete: true
Attachment #569787 -
Flags: review?(bjacob)
Attachment #570030 -
Flags: review?(bjacob)
|
|
Assignee | |
Comment 5•13 years ago
|
||
Unbitrot.
Attachment #569788 -
Attachment is obsolete: true
Attachment #569788 -
Flags: review?(bjacob)
Attachment #570031 -
Flags: review?(bjacob)
|
||
Updated•13 years ago
|
Attachment #570030 -
Flags: review?(bjacob) → review+
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 570031 [details] [diff] [review]
Patch 2: Disallow conformance test failures for 'read-pixels-test'
Review of attachment 570031 [details] [diff] [review]:
-----------------------------------------------------------------
fold into other patch.
Attachment #570031 -
Flags: review?(bjacob) → review+
|
|
Assignee | |
Updated•13 years ago
|
Blocks: webgl-conformance
|
|
Assignee | |
Comment 7•13 years ago
|
||
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
|
|
Assignee | |
Comment 8•13 years ago
|
||
r+ carryover from bjacob.
Attachment #570030 -
Attachment is obsolete: true
Attachment #570031 -
Attachment is obsolete: true
Attachment #570885 -
Flags: review+
|
|
Assignee | |
Comment 9•13 years ago
|
||
That was what was pushed. I just forgot to upload the new version before pushing.
|
|
Assignee | |
Comment 10•13 years ago
|
||
Removed [inbound] from whiteboard as per https://wiki.mozilla.org/Tree_Rules/Inbound
Whiteboard: [inbound]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•