| This bug describes changes to the version of the downloads panel and | indicator that is currently present in the UX branch, more specifically: | * Bug 564934, attachment 558500 [details] [diff] [review] | * Bug 663772, attachment 558504 [details] [diff] [review] | | Patches for this bug should apply on top of the two mentioned patches. The indicator should be updated accordingly to the UI mockup in the bug's URL: * Same basic style as a toolbar button. - Note: sometimes, on Windows, clicking the indicator's background doesn't work and the panel isn't opened. This is often observed when the indicator is on the title bar. Verify that the new button style works in all cases. * Fixed width, same as the Bookmarks button. * Always visible, even if there are no downloads in the list. * Small version of the "downloads" icon when the progress bar is visible. - If no time left indication is available, center the icon. - If there is a time left indication and enough room for both the icon and the text, show both (I suppose it's better to avoid slight movements of the icon by reserving room for the maximum possible text width, but it's also possible to just center the icon and the text together). - If there is a time left indication and no room for the icon, show the time indication only. * The animation for new downloads should move from the page towards the button. It should always have an angle of 45° and animate into the arrow, if visible (depending on the button state). * The progress bar in the button should remain visible and become yellow when there are paused downloads. If the current overall download progress is available, if should be displayed in the button. Also, investigate what the paused state currently looks like in the task bar of Windows 7 and Windows Vista and possibly use similar colors on that platform. Code for most of these states of the indicator exists in attachment 550151 [details] [diff] [review].

(In reply to Paolo Amadini from comment #0) > * The progress bar in the button should remain visible and become yellow when > there are paused downloads. If the current overall download progress is > available, if should be displayed in the button. Also, investigate what > the paused state currently looks like in the task bar of Windows 7 and > Windows Vista and possibly use similar colors on that platform. > Paused downloads in IE9 cause the taskbar progress to disappear. The taskbar progress reappears when the download is resumed. If we want to turn the progress bar to yellow, I think that we should stop displaying the progress bar some period of time after the download has been paused, under the assumption that it will never be resumed.

(In reply to Jared Wein [:jwein and :jaws] from comment #1) > If we want to turn the progress bar to yellow, I think that we should stop > displaying the progress bar some period of time after the download has been > paused, under the assumption that it will never be resumed. If we assume that a download will never be resumed, then it's reasonable to make sure that any temporary files associated with it are deleted, and that the entry is removed from the panel on first occasion (last browser window closed). So, in case we decide to expire paused downloads, it should be done in the data layer, in a separate bug. In this bug, we should just make sure that the indicator mirrors what the data layer says, initially based just on the count of paused downloads from the Download Manager service (see attachment 550151 [details] [diff] [review]).

making assumptions on the user's will may be hard, I may pause a download because on that day I need to do some online work needing bandwidth and willing to resume it the day after. Stopping notifying a paused download after a certain amount of time may make sense though, to stop distracting the user with a constant information. It is more of a polish thing though, I'd rather leave this to a later stage.

Paolo has said that he may have more time than I to contribute towards this bug.

(In reply to Jared Wein [:jwein and :jaws] from comment #4) > Paolo has said that he may have more time than I to contribute towards this > bug. Yes, hopefully :-) I'll work on top of the in-progress patch you sent me. Thank you for the work you've already done!

> - If there is a time left indication and enough room for both the icon and > the text, show both (I suppose it's better to avoid slight movements of > the icon by reserving room for the maximum possible text width, but it's > also possible to just center the icon and the text together). On Windows, it looks like there is never enough room for both the icon and the text, if keeping the same width as the Bookmarks button. For now I've made the two exclusive with each other, on all platforms. In fact, this is controlled entirely by CSS rules so we could even make that different across platforms. > * The animation for new downloads should move from the page towards the > button. It should always have an angle of 45° and animate into the arrow, > if visible (depending on the button state). For now there is no code that detects the position of the button, thus the direction of the animation is fixed. The animation won't be visible if the button is placed in the lower part of the screen or on the opposite side to the default. > * The progress bar in the button should remain visible and become yellow when > there are paused downloads. Colors and styling are temporary, until the visual design team works on them. At least the bar should look yellowish now, when there is a paused download.

I was looking at the latest trybuild, I noticed a couple things, I'm posting here even if may be OT for the most part, but you know better what is already tracked and what changed here. - the empty panel looks bad, there is an empty white rectangle and, below it, there is the panel footer with the blue gradient. We should either special case the style here to only show the footer (still the gradient would be wrong), or show a centered "No recent downloads." grey text in the empty part. Imo the latter is self documenting to the user what the panel is about. - the arrow animation is imo too opaque (at the beginning), slow and thus I find it annoying. I actually preferred the previous one, but may just be just me. - removing any trace of the downloaded file sounds like a complicate task. Is it by design? What's the shortest way we will support? This is imo an important privacy tool. - the remaining time text, on Glass, is still hard to read. - on pause, the progress bar background becomes yellow-ish, but it's really hard to distinguish it from the green-ish background. I barely see a difference if I pause a download near the beginning. It's clearly more visible if I pause it later since the bar is brighter. - Open containing folder context menu option is visible but disabled when a download is paused or when it's proceeding. Not visible at all on finished downloads. Looks bogus?

Comment on attachment 580021 [details] [diff] [review] The patch Review of attachment 580021 [details] [diff] [review]: ----------------------------------------------------------------- looks ok, please take a look at my previous comment though. ::: browser/components/downloads/content/indicator.js @@ +326,2 @@ > this._notificationTimeout = setTimeout( > + function() indicator.removeAttribute("notification"), 1000); nit: too much indented

The patch on this bug is now included as part of the patch in bug 726444. Any pending issue here should have already been filed as one of the bug's follow-ups.