Closed
Bug 699101
Opened 13 years ago
Closed 13 years ago
NO_MAC_JEMALLOC can't work on 10.5, so display a warning when it's specified
Categories
(Core :: Memory Allocator, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
| Tracking | Status | |
|---|---|---|
| firefox10 | --- | fixed |
People
(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Patch in a moment.
|
Assignee | |
Comment 1•13 years ago
|
||
* memalign is unavailable on Leopard, so we can't dynamically do this there.
* However, we don't use jemalloc on Leopard, so we can ignore this.
*/
#if defined(MOZ_MEMORY_DARWIN) && !defined(__i386__)
So now we *are* using jemalloc on Leopard.
When does MEMALIGN get called? If MEMALIGN is called and we're not using jemalloc, what the heck are we supposed to do? Crash?
|
|
Assignee | |
Comment 2•13 years ago
|
||
I should have given more context in comment 1. It's
#if defined(MOZ_MEMORY_DARWIN) && !defined(__i386__)
#define DARWIN_ONLY(A) if (!osx_use_jemalloc) { A; }
#else
#define DARWIN_ONLY(A)
#endif
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
|
Assignee | |
Comment 4•13 years ago
|
||
So, memalign is apparently called on 10.5. I guess this means that we can't dynamically turn off jemalloc there. Not a huge deal; this is only for testing, anyway.
I'll post a patch fixing the comment.
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #571460 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #571355 -
Attachment is obsolete: true
Attachment #571460 -
Flags: review?(khuey) → review+
Assignee: nobody → justin.lebar+bug
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•13 years ago
|
Attachment #571460 -
Attachment description: Patch v1 → Patch v2
|
|
Assignee | |
Updated•13 years ago
|
Summary: jemalloc's DARWIN_ONLY macro doesn't work on i386, breaking NO_MAC_JEMALLOC → NO_MAC_JEMALLOC can't work on 10.5, so display a warning when it's specified
|
|
Assignee | |
Comment 6•13 years ago
|
||
status-firefox10:
--- → fixed
|
||
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Is there a testcase QA can use to verify this fix?
Whiteboard: [qa?]
|
|
Assignee | |
Comment 9•13 years ago
|
||
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #8)
> Is there a testcase QA can use to verify this fix?
No.
You need to log in
before you can comment on or make changes to this bug.
Description
•