Closed Bug 699323 Opened 13 years ago Closed 7 years ago

Can parts of SetArrayElement be fast-pathed when we know we have a dense array with sufficient capacity?

Categories

(Core :: JavaScript Engine, defect)

7 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1362753

People

(Reporter: bzbarsky, Unassigned)

References

Details

SetArrayElement shows up high on slice() profiles. At first glance, array_slice makes sure the result value is a dense array of sufficient size. So a lot of the stuff SetArrayElement does (e.g. ensureDenseArrayCapacity) seems unnecessary. If that's actually the case, can we fast-path it?
Blocks: 697343
Assignee: general → nobody
Argh, hit enter while the focus was still in the duplicate-bug input box. What I meant to say: The current slice() fast path [1] should work quite nice for dense arrays. Then there's an additional hook in [2] and bug 1362753 made the non-fast path a bit faster, too. Therefore marking as dup of bug 1362753.
You need to log in before you can comment on or make changes to this bug.