Closed
Bug 699459
Opened 13 years ago
Closed 13 years ago
Add a pref to disable Battery API
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: mounir, Assigned: mounir)
References
Details
(Keywords: user-doc-needed)
Attachments
(1 file)
|
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
Something like "dom.battery.enabled". true by default but can be turned false. In that case, I don't know if navigator.mozBattery should return null or if we should return the default values. I'm worried returning null might break some websites.
|
||
Comment 1•13 years ago
|
||
Or not be exposed at all?
The property shouldn't be defined at all. That's what we do for other preffable DOM features.
See nsIDOMStorageIndexedDB.
|
Assignee | |
Comment 3•13 years ago
|
||
That would be better indeed but that would make changing the pref during run time useless, right? Seems a fair trade though.
|
|
||
Comment 4•13 years ago
|
||
> That would be better indeed but that would make changing the pref during run time
> useless,
Depends on how we implement. If we look at the pref during prototype setup, then flipping the pref and reloading the page would work. If we only look at it during the classinfo initialization stuff then flipping it would need a browser restart, yes.
|
|
Assignee | |
Updated•13 years ago
|
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #571817 -
Flags: review?(jonas)
|
|
Assignee | |
Comment 6•13 years ago
|
||
We should probably push this before the Aurora uplift (the 8th). Worst case, we could directly push it to Aurora but better to prevent this.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla10
Attachment #571817 -
Flags: review?(jonas) → review+
|
||
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•