Closed
Bug 699741
Opened 13 years ago
Closed 13 years ago
Do not prevent sending levelchange event if the change is less than 0.01
Categories
(Core Graveyard :: Widget: Android, defect)
Core Graveyard
Widget: Android
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla11
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
(deleted),
patch
|
cjones
:
review+
asa
:
approval-mozilla-aurora-
|
Details | Diff | Splinter Review |
The specs required that but do not anymore. In addition, the backend should be smart enough to not send us too many events. If not, we will be able to tweak that later. In the meantime, let's have a simple implementation.
Assignee | ||
Comment 1•13 years ago
|
||
The Android backend is still going to check if there is a change which the upower backend does not because the DOM code already checks that before sending the events. The idea is to prevent going through JNI then from the parent process to the child process to finally not send the event.
Attachment #571926 -
Flags: review?(jones.chris.g)
Updated•13 years ago
|
Attachment #571926 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Updated•13 years ago
|
Flags: in-testsuite-
Assignee | ||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 571926 [details] [diff] [review]
Patch v1
This has just landed in mozilla-inbound. Requesting aurora approval for API completeness in Firefox 10. It would be better to ship Firefox 10 with the entire API if we say it is present. The risk is very low given that there is no use of the API for the moment.
Attachment #571926 -
Flags: approval-mozilla-aurora?
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Comment 4•13 years ago
|
||
Comment on attachment 571926 [details] [diff] [review]
Patch v1
It looks like this feature wasn't ready for 10. Please re-nominate if you have a good justification for trying to get this into 10 rather than just waiting for 11.
Attachment #571926 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•