Closed
Bug 700764
Opened 13 years ago
Closed 13 years ago
Esc doesn't make iframe leave DOM fullscreen mode
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
VERIFIED
FIXED
mozilla11
| Tracking | Status | |
|---|---|---|
| firefox8 | --- | unaffected |
| firefox9 | --- | unaffected |
| firefox10 | + | verified |
| firefox11 | --- | verified |
People
(Reporter: daniel.nr01, Assigned: cpearce)
References
()
Details
(Keywords: verified-beta, Whiteboard: [qa!])
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
asa
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111102223350
Steps to reproduce:
Viewing an iframe in DOM full-screen mode pressing the escape key doesn't make it leave fullscreen.
str
1. Open http://www.thecssninja.com/demo/fullscreen/
2. Click the "Fullscreen iframe" button
3. Click anywhere inside the iframe
4. Now pressing escape has no effect
|
||
Updated•13 years ago
|
tracking-firefox10:
--- → ?
|
Assignee | |
Comment 1•13 years ago
|
||
So the issue here is that if you focus a non-fullscreen frame the key events won't go through the full-screen document's presshell's event handler. We should ensure that ESC *always* exits full-screen, and so check if the root document is full-screen rather than if the focused document is in PresShell::HandleEventInternal().
Component: General → DOM: Core & HTML
QA Contact: general → general
|
|
Assignee | |
Comment 2•13 years ago
|
||
Instead of checking if a keyevent's target document is full-screen, check if the root document is full-screen, and exit if ESC is pressed. This means if ESC is pressed when a non-full-screen iframe which is contained inside a full-screen document is focused, you'll still exit full-screen.
Assignee: nobody → chris
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #574195 -
Flags: review?(bugs)
|
||
Updated•13 years ago
|
Attachment #574195 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
|
|
Assignee | |
Updated•13 years ago
|
status-firefox10:
--- → affected
status-firefox11:
--- → fixed
status-firefox8:
--- → unaffected
status-firefox9:
--- → unaffected
|
|
Assignee | |
Comment 5•13 years ago
|
||
Comment on attachment 574195 [details] [diff] [review]
Patch
Requesting approval for Aurora because this bug prevents the a simple way to avoid the "Press ESC to leave full-screen" warning when in full-screen mode. Without this we're vulnerable to phishing.
Attachment #574195 -
Flags: approval-mozilla-aurora?
|
||
Updated•13 years ago
|
Attachment #574195 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 6•13 years ago
|
||
|
||
Comment 7•13 years ago
|
||
ESC key works fine now. This is verified fixed on Firefox 10 Beta2:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20100101 Firefox/10.0
Whiteboard: [qa+] → [qa+][qa!:10]
|
|
||
Updated•13 years ago
|
Keywords: verified-beta
|
||
Updated•13 years ago
|
|
|
||
Comment 8•13 years ago
|
||
This is verified fixed on Firefox 11b1:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0
You need to log in
before you can comment on or make changes to this bug.
Description
•