Closed
Bug 700854
Opened 13 years ago
Closed 13 years ago
{Media,Image,Video}Document should reference an external stylesheet for use in styling their contents
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: jaws, Assigned: jaws)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
MediaDocument.cpp, ImageDocument.cpp, and VideoDocument.cpp should reference an external stylesheet.
We need to move the styles out to an external stylesheet before we can fix bug 376997.
|
Assignee | |
Comment 1•13 years ago
|
||
This patch is part of the patch for bug 376997. I have pushed it to the tryserver: https://tbpl.mozilla.org/?tree=Try&rev=5525e6d4e319
There should be no UI changes with this patch, it is just to setup the plumbing for bug 700856.
Attachment #573043 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
This patch references a ImageDocument.css and VideoDocument.css instead of MediaDocument.css. Styles will be moved to the stylesheets in bug 700856, which I'll land at the same time.
I couldn't push to try because of bug 701232.
Attachment #573043 -
Attachment is obsolete: true
Attachment #573374 -
Flags: review?(roc)
Comment on attachment 573374 [details] [diff] [review]
Patch for bug 700854
Review of attachment 573374 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/html/document/src/VideoDocument.cpp
@@ +151,5 @@
> +
> + link->SetAttr(kNameSpaceID_None, nsGkAtoms::href,
> + NS_LITERAL_STRING("resource://gre/res/VideoDocument.css"), true);
> +
> + head->AppendChildTo(link, false);
Create a superclass helper function to share this code.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Moved the duplicated code to a function within MediaDocument.
Attachment #573374 -
Attachment is obsolete: true
Attachment #573374 -
Flags: review?(roc)
Attachment #573390 -
Flags: review?(roc)
Attachment #573390 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Carrying forward r+ from roc. I've renamed the CSS files to TopLevel*Document.css since they only apply when the synthetic document is top level.
Pushed to try and waiting to land with bug 700856.
https://tbpl.mozilla.org/?tree=Try&rev=816cb0059256
Attachment #573390 -
Attachment is obsolete: true
Attachment #573558 -
Flags: review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
|
|
||
Comment 8•13 years ago
|
||
|
||
Comment 9•13 years ago
|
||
Why are these in /res/ ?
Themers (like me) want to theme the background of these pages, so that it would fit better in there theme.
You need to log in
before you can comment on or make changes to this bug.
Description
•