Closed
Bug 700959
Opened 13 years ago
Closed 13 years ago
Enable incremental linking on 64-bit Windows, but not on 32-bit
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox10 fixed)
RESOLVED
FIXED
mozilla11
Tracking | Status | |
---|---|---|
firefox10 | --- | fixed |
People
(Reporter: sgautherie, Assigned: rain1)
References
Details
(Keywords: regression, Whiteboard: fixed-in-bs [qa-])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
ted
:
review+
asa
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Per bug 653662 and bug 696627 discussions.
Reporter | ||
Comment 1•13 years ago
|
||
Fwiw:
(In reply to neil@parkwaycc.co.uk from bug 653662 comment #24)
> What's actually tipping the ilk over the limit? MOZ_DEBUG is a sledgehammer,
> so if you do subsequently tweak the condition you might want to consider
> conditioning on MOZ_DEBUG_SYMBOLS or MOZ_OPTIMIZE instead as appropriate.
Assignee | ||
Comment 2•13 years ago
|
||
http://social.msdn.microsoft.com/Forums/en-US/vcgeneral/thread/c34d5c37-ca4a-4580-9c7c-4379a8c76d1f/ indicates that enabling it should be fine on VC9/64 too.
Assignee: nobody → sagarwal
Status: NEW → ASSIGNED
Attachment #573156 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #573156 -
Attachment is obsolete: true
Attachment #573156 -
Flags: review?(ted.mielczarek)
Attachment #573163 -
Flags: review?(ted.mielczarek)
Comment 4•13 years ago
|
||
Comment on attachment 573163 [details] [diff] [review]
better patch
[Checked in: Comment 10 & 11]
Review of attachment 573163 [details] [diff] [review]:
-----------------------------------------------------------------
Ugh. GNU Make makes me sad. :-(
Attachment #573163 -
Flags: review?(ted.mielczarek) → review+
Comment 5•13 years ago
|
||
Can we take this patch on Aurora? Otherwise some supported build setups won't work for some people in fx10.
Reporter | ||
Updated•13 years ago
|
Attachment #573163 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 6•13 years ago
|
||
Whiteboard: fixed-in-bs
Assignee | ||
Comment 7•13 years ago
|
||
If this needs to land in Aurora urgently could someone else land it please? I'm on mobile internet until Monday and don't have a fresh Aurora checkout.
Assignee | ||
Comment 8•13 years ago
|
||
Oh, and this should be low risk enough because it doesn't affect any tinderbox builds.
Updated•13 years ago
|
Attachment #573163 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Comment 9•13 years ago
|
||
Ftr, mozilla-beta is not affected (yet):
http://mxr.mozilla.org/mozilla-beta/source/toolkit/library/Makefile.in#131
Updated•13 years ago
|
Target Milestone: --- → mozilla11
Comment 10•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•13 years ago
|
||
status-firefox10:
--- → fixed
Reporter | ||
Updated•13 years ago
|
Attachment #573163 -
Attachment description: better patch → better patch
[Checked in: Comment 11]
Reporter | ||
Updated•13 years ago
|
Flags: in-testsuite-
Whiteboard: fixed-in-bs → [ToDo: check in to m-a] [fixed-in-bs]
Reporter | ||
Updated•13 years ago
|
Attachment #573163 -
Attachment description: better patch
[Checked in: Comment 11] → better patch
[Checked in: Comment 10 & 11]
Reporter | ||
Updated•13 years ago
|
Whiteboard: [ToDo: check in to m-a] [fixed-in-bs] → fixed-in-bs
Comment 12•13 years ago
|
||
Marking qa- as I don't think this is something QA needs to verify. Please set to qa+ if this is not the case.
Whiteboard: fixed-in-bs → fixed-in-bs [qa-]
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•