Closed
Bug 70112
Opened 24 years ago
Closed 24 years ago
Move "About Mozilla" from properties to dtd
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jag+mozbugs, Assigned: jag+mozbugs)
Details
Attachments
(7 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
This means we can remove helpMenuCreate() from utilityOverlay.js, but it also
means changing the Mac code which now reads from that properties file to instead
get the label from the menuitem.
Attaching a few patches soon.
Assignee | ||
Comment 1•24 years ago
|
||
Assignee | ||
Comment 2•24 years ago
|
||
Note: the above patch is completely untested, I wouldn't mind some Mac help,
cc'ing saari.
Attaching patches for the XP part.
Note2: once those patches are applied, the first patch should be changed to also
do s/releaseName/aboutName/
Assignee | ||
Comment 3•24 years ago
|
||
Assignee | ||
Comment 4•24 years ago
|
||
Assignee | ||
Comment 5•24 years ago
|
||
timeless noted that when releaseUrl was moved from brand.properties to
region.properties it was incorrectly changed from
<http://www.mozilla.org/releases/> to
<http://www.mozilla.org/projects/seamonkey/release-notes/>
I'll undo that change before checking in.
Assignee | ||
Comment 7•24 years ago
|
||
So it seems like the first patch needs to #include "nsHTMLAtoms.h" to work and
the .mcp will probably need to be modified to add an include path directly to
the source dir (this is what other places / unix makefiles seem to do).
Currently it will put "About" in the Mac help menu, but with patch 2 applied and
changing "releaseName" to "aboutName" in patch 1 it should say "About Mozilla"
or "About Netscape 6".
"Should" being the operative word here. If someone could confirm this for me
I'll attach the new patch.
Comment 8•24 years ago
|
||
i had to make some (minor) changes to the patches, but after doing that, this
worked on mac.
Assignee | ||
Comment 9•24 years ago
|
||
Assignee | ||
Comment 10•24 years ago
|
||
Assignee | ||
Comment 11•24 years ago
|
||
Comment 12•24 years ago
|
||
looks good to me, r=saari
Assignee | ||
Comment 14•24 years ago
|
||
Assignee | ||
Comment 15•24 years ago
|
||
okay, checked in, marking fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•