Closed Bug 701221 Opened 13 years ago Closed 13 years ago

Cannot install purchased app ('Thank You' lightbox still open, JavaScript is unresponsive)

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: krupa.mozbugs, Assigned: potch)

References

Details

Attachments

(1 file)

steps to reproduce: 1. Load https://addons-dev.allizom.org/en-US/apps/app/birdwalker/ 2. Purchase the app reproducible: sometimes actual behavior: Sometimes, the 'Thank You' lightbox opens when the paypal modal is still open. See screenshot.
Attached image screenshot (deleted) —
Priority: -- → P5
I hit this again today. I saw this exception: [15:22:29.876] uncaught exception: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIDOMJSWindow.setTimeout]" nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)" location: "JS frame :: https://addons-dev-cdn.allizom.org/media/js/common-min.js?build=652edf4 :: <TOP_LEVEL> :: line 7" data: no]
I was able to reproduce this locally. It points to zamboni/global.js line 355 $modal.render = function() { var p = $modal.o; $modal.hider = makeBlurHideCallback($modal); if (p.hideme) { -> setTimeout(function(){ $(document.body).bind('click modal', $modal.hider); }, 0); } ...} Greg, ideas? Contrary to the screenshot here, I did not have a paypal popup. It was using the paypal lightbox modal.
Temporary hack / workaround so that this isn't breaking purchases for demos, etc. https://github.com/mozilla/zamboni/commit/f954b0fcd48f384a338781fed2ee14adccca6859
Summary: Sometimes, the 'Thank You' lightbox opens when the paypal modal is still open → Cannot install purchased app ('Thank You' lightbox still open, JavaScript is unresponsive)
Weird. I remember writing code similar to that for the benefit of Chrome, however that particular line was written by Potch a long, long time ago (before I started). So, I'm not entirely sure why it's there. If I had to guess, though, it has something to do with paypal's top_opener. Potch?
Sometimes, the Thank you modal doesn't load at all. See http://screencast.com/t/TLkWMnWk
I think this is related to bug 704534.
-> potch for comment 5. I'm not sure if this is important or not, but if it's related to bug 704534 we should at least clarify.
Assignee: nobody → thepotch
Priority: P5 → P2
Target Milestone: --- → 6.3.4
I can't repro this, marking fixed.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: