Closed
Bug 701221
Opened 13 years ago
Closed 13 years ago
Cannot install purchased app ('Thank You' lightbox still open, JavaScript is unresponsive)
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect, P2)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
RESOLVED
FIXED
6.3.4
People
(Reporter: krupa.mozbugs, Assigned: potch)
References
Details
Attachments
(1 file)
(deleted),
image/png
|
Details |
steps to reproduce:
1. Load https://addons-dev.allizom.org/en-US/apps/app/birdwalker/
2. Purchase the app
reproducible: sometimes
actual behavior:
Sometimes, the 'Thank You' lightbox opens when the paypal modal is still open. See screenshot.
Reporter | ||
Comment 1•13 years ago
|
||
Updated•13 years ago
|
Priority: -- → P5
Reporter | ||
Comment 2•13 years ago
|
||
I hit this again today. I saw this exception:
[15:22:29.876] uncaught exception: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIDOMJSWindow.setTimeout]" nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)" location: "JS frame :: https://addons-dev-cdn.allizom.org/media/js/common-min.js?build=652edf4 :: <TOP_LEVEL> :: line 7" data: no]
Comment 3•13 years ago
|
||
I was able to reproduce this locally. It points to zamboni/global.js line 355
$modal.render = function() {
var p = $modal.o;
$modal.hider = makeBlurHideCallback($modal);
if (p.hideme) {
-> setTimeout(function(){
$(document.body).bind('click modal', $modal.hider);
}, 0);
}
...}
Greg, ideas? Contrary to the screenshot here, I did not have a paypal popup. It was using the paypal lightbox modal.
Comment 4•13 years ago
|
||
Temporary hack / workaround so that this isn't breaking purchases for demos, etc. https://github.com/mozilla/zamboni/commit/f954b0fcd48f384a338781fed2ee14adccca6859
Updated•13 years ago
|
Summary: Sometimes, the 'Thank You' lightbox opens when the paypal modal is still open → Cannot install purchased app ('Thank You' lightbox still open, JavaScript is unresponsive)
Comment 5•13 years ago
|
||
Weird. I remember writing code similar to that for the benefit of Chrome, however that particular line was written by Potch a long, long time ago (before I started). So, I'm not entirely sure why it's there. If I had to guess, though, it has something to do with paypal's top_opener.
Potch?
Reporter | ||
Comment 6•13 years ago
|
||
Sometimes, the Thank you modal doesn't load at all. See http://screencast.com/t/TLkWMnWk
Comment 7•13 years ago
|
||
I think this is related to bug 704534.
Comment 8•13 years ago
|
||
-> potch for comment 5. I'm not sure if this is important or not, but if it's related to bug 704534 we should at least clarify.
Assignee: nobody → thepotch
Priority: P5 → P2
Target Milestone: --- → 6.3.4
Comment 9•13 years ago
|
||
I think this was fixed in https://github.com/mozilla/zamboni/commit/2494ce94fe9890614538e80cbbc9bdb65faed83e but potch can verify that.
Assignee | ||
Comment 10•13 years ago
|
||
I can't repro this, marking fixed.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•