Closed
Bug 701260
Opened 13 years ago
Closed 13 years ago
Deny requests for DOM full-screen when windowed plugins are present in the entire doc tree
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
(Whiteboard: [inbound][qa?])
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
christian
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Currently the check which prevents us going full-screen when a doctree contains a windowed plugin only checks the document and its subdocuments, whereas it should check every document in the target document's branch (but not in other branches/tabs).
|
Assignee | |
Comment 1•13 years ago
|
||
Change to deny requests for full-screen if any doc in the tab has a windowed plugin, rather than if the requesting doc or its subdocs have windowed plugins.
I have tests, but the tests leak on tryserver (even without this patch applied!), so I'll not put the tests up for review.
Attachment #574747 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Whiteboard: [inbound]
Target Milestone: --- → mozilla11
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•13 years ago
|
status-firefox10:
--- → affected
status-firefox11:
--- → fixed
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 574747 [details] [diff] [review]
Patch
Requesting approval for Aurora, because this fix prevents a work-around which enables keyboard input in full-screen mode which doesn't cause the "Press ESC to leave full-screen mode" warning to pop up. We need this to help protect against phishing attacks.
Attachment #574747 -
Flags: approval-mozilla-aurora?
Comment on attachment 574747 [details] [diff] [review]
Patch
[triage comment]
Approved for aurora. Please land as soon as possible
Attachment #574747 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 6•13 years ago
|
||
Target Milestone: mozilla11 → mozilla10
Is this something QA can verify?
Whiteboard: [inbound] → [inbound][qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #7)
> Is this something QA can verify?
bump
You need to log in
before you can comment on or make changes to this bug.
Description
•