Closed Bug 702094 Opened 13 years ago Closed 13 years ago

Dragging attachments from the compose window doesn't work anymore

Categories

(Thunderbird :: Message Compose Window, defect)

Product:
Thunderbird
Component:
Message Compose Window
Version:
8 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird9 fixed, thunderbird10 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 11.0
Tracking Flags:
Tracking Status
thunderbird9 --- fixed
thunderbird10 --- fixed

People

(Reporter: squib, Assigned: squib)

References

Details

Attachments

(1 file, 1 obsolete file)

Attach the right patch this time
(deleted), patch
bwinton
: review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review
Attached patch Fix this (obsolete) (deleted) — — Splinter Review
Bug 630759 broke this because I forgot to update a string in MsgComposeCommands.js. Here's the fix. I could write tests for this, but inter-window drag-and-drop tests are fairly complicated, so I'm going to avoid doing it unless specifically requested. :)
Attachment #574130 - Flags: review?(bwinton)
This patch does a lot more than just fixing the drag problem (lots of "renameAttachment" changes from bug 526998 in here as well)... Not sure if such mixed patches are intended or desired?
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → 8
Oops. The previous patch had some extra changes that stowed away.
Assignee: nobody → squibblyflabbetydoo
Attachment #574130 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #574130 - Flags: review?(bwinton)
Attachment #574170 - Flags: review?(bwinton)
Comment on attachment 574170 [details] [diff] [review] Attach the right patch this time Review of attachment 574170 [details] [diff] [review]: ----------------------------------------------------------------- Seems to work for me.
Attachment #574170 - Flags: review?(bwinton) → review+
Attachment #574170 - Flags: approval-comm-beta?
Attachment #574170 - Flags: approval-comm-aurora?
Checked in: http://hg.mozilla.org/comm-central/rev/e4c895f1d759
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
(In reply to Jim Porter (:squib) from comment #5) > Checked in: http://hg.mozilla.org/comm-central/rev/e4c895f1d759 How might I apply this patch to my local copy of Thunderbird? Thank you.
(In reply to Jim Porter (:squib) from comment #0) > Bug 630759 broke this because I forgot to update a string in > MsgComposeCommands.js. Here's the fix. I could write tests for this, but > inter-window drag-and-drop tests are fairly complicated, so I'm going to > avoid doing it unless specifically requested. :) We should get some litmus tests then ;-)
Flags: in-litmus?(ludovic)
Attachment #574170 - Flags: approval-comm-beta?
Attachment #574170 - Flags: approval-comm-beta+
Attachment #574170 - Flags: approval-comm-aurora?
Attachment #574170 - Flags: approval-comm-aurora+
What was broken here ? dragging from one compose window to another ?
Blocks: 304835
Flags: in-litmus?(ludovic)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: