Closed
Bug 702225
Opened 13 years ago
Closed 13 years ago
Implement revised nav bar button appearance on Windows
Categories
(Firefox :: Theme, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 13
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
(deleted),
patch
|
shorlander
:
review+
|
Details | Diff | Splinter Review |
Attachment #574270 -
Flags: review?(shorlander)
Assignee | ||
Updated•13 years ago
|
Summary: Implement revised nav bar button texture on Windows → Implement revised nav bar button appearance on Windows
Assignee | ||
Updated•13 years ago
|
Blocks: australis-navbar
Assignee | ||
Comment 2•13 years ago
|
||
Stephen, could you please review this? It's ok if textures, borders etc. aren't quite perfect, as we can easily tweak them (about to happen in bug 727650).
Comment 3•13 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #2)
> Stephen, could you please review this? It's ok if textures, borders etc.
> aren't quite perfect, as we can easily tweak them (about to happen in bug
> 727650).
Yes! I will review this right now. Really sorry for the delay I have no idea how this fell off my radar.
Comment 4•13 years ago
|
||
Comment on attachment 574270 [details] [diff] [review]
patch
Review of attachment 574270 [details] [diff] [review]:
-----------------------------------------------------------------
(In reply to Dão Gottwald [:dao] from comment #2)
> Stephen, could you please review this? It's ok if textures, borders etc.
> aren't quite perfect, as we can easily tweak them (about to happen in bug
> 727650).
Looks good!
The only thing I noticed was that the #forward-button mask works on hover but distorts when pressed: http://cl.ly/1G2Z1i1F2B412r053344
Maybe fix it the same way as the hover/non-hover states?
>+ box-shadow: 0 1px 0 rgba(255,255,255,.3) inset,
>+ 0 0 0 1px rgba(255,255,255,.3) inset,
>+ 0 1px 0 hsla(210,54%,20%,.02),
>+ /* allows winstripe-keyhole-forward-mask to be used for non-hover as well as hover: */
>+ 0 0 2px hsla(210,54%,20%,0);
+ box-shadow: 0 1px 1px rgba(0,0,0,.1) inset,
+ 0 0 2px rgba(0,0,0,.3) inset,
+ /* allows winstripe-keyhole-forward-mask to be used for active as well as non-hover and hover: */
+ 0 1px 0 hsla(210,54%,20%,0),
+ 0 0 2px hsla(210,54%,20%,0);
Attachment #574270 -
Flags: review?(shorlander) → review+
Assignee | ||
Comment 5•13 years ago
|
||
> The only thing I noticed was that the #forward-button mask works on hover
> but distorts when pressed: http://cl.ly/1G2Z1i1F2B412r053344
>
> Maybe fix it the same way as the hover/non-hover states?
>
> >+ box-shadow: 0 1px 0 rgba(255,255,255,.3) inset,
> >+ 0 0 0 1px rgba(255,255,255,.3) inset,
> >+ 0 1px 0 hsla(210,54%,20%,.02),
> >+ /* allows winstripe-keyhole-forward-mask to be used for non-hover as well as hover: */
> >+ 0 0 2px hsla(210,54%,20%,0);
>
> + box-shadow: 0 1px 1px rgba(0,0,0,.1) inset,
> + 0 0 2px rgba(0,0,0,.3) inset,
> + /* allows winstripe-keyhole-forward-mask to be used for
> active as well as non-hover and hover: */
> + 0 1px 0 hsla(210,54%,20%,0),
> + 0 0 2px hsla(210,54%,20%,0);
done
http://hg.mozilla.org/integration/mozilla-inbound/rev/8bca9af04102
Target Milestone: --- → Firefox 13
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 7•13 years ago
|
||
@Dao: Is there a bug filed for the Panorama button becoming white with dark personas when on the navigation toolbar (with large icon mode and tabs on top)?
Assignee | ||
Updated•13 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•