Closed
Bug 70228
Opened 24 years ago
Closed 24 years ago
nsIHelperAppLauncherDialog needs to be used as a component rather than a service
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: jud, Assigned: law)
References
()
Details
(Whiteboard: Apr 19)
the users of this should be doing a createinstance rather than a get service. we
also need to move this over into the URI loader dir.
Reporter | ||
Updated•24 years ago
|
Blocks: 70229
Summary: [API]nsIHelperAppLauncherDialog needs to be used as a component rather than a service → nsIHelperAppLauncherDialog needs to be used as a component rather than a service
Setting milestone and nominating. Wishful thinking, maybe.
Keywords: nsbeta1
Target Milestone: --- → mozilla0.9.1
Clarification: this needs to be moved over to the new
embedding/components/ui/helperApps dir, not the URI loader, correct?
Reporter | ||
Comment 3•24 years ago
|
||
I'm not sure where' dan's putting all this stuff. Also, shouldn't this be a
blocker for your dialog bug(s) dan?
This is fixed as part of my fix for bug 52454.
I wasn't imagining moving all these UI-controlling components into the
embedding directory. I look at them as still belonging more to the code whose UI
they define than to the embedded world. I was thinking of just leaving them with
the component whose UI they were controlling. I've only moved the nsIPrompt stuff
into embedding because it was part of appshell, and I have this dream that
appshell shouldn't need to be part of an embedded distribution. So sometimes I
deram small.
Yeah, I'll add it to my UI meta bug so it'll look bigger.
Reporter | ||
Comment 6•24 years ago
|
||
I second that. the UI belongs to the component needing/throwing it (usually).
Spam: new helper app dialog not making mozilla0.9, unfortunately.
Target Milestone: mozilla0.9 → mozilla0.9.1
OK, moving back to mozilla0.9 'cause these are "embedding" bugs.
Target Milestone: mozilla0.9.1 → mozilla1.2
Putting date in status whiteboard to match blocking bug 52454 (watch that bug
for any real news).
Whiteboard: Apr 19
Comment 11•24 years ago
|
||
Correction: Changing QA contact for the Embed API bugs to David Epstein.
QA Contact: mdunn → depstein
Comment 12•24 years ago
|
||
Bill, you can move this to 0.9.1, unless you have other need for it in 0.9.
Assignee | ||
Comment 13•24 years ago
|
||
We changed our minds; targetting 0.9.1 now.
Target Milestone: mozilla0.9 → mozilla0.9.1
Assignee | ||
Comment 14•24 years ago
|
||
fixed (part of bug 52454)
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 15•24 years ago
|
||
nsIHelperAppLauncherDialog object gets created with a do_CreateInstance().
verified in testembed (Verify Bugs > 70228).
http://lxr.mozilla.org/seamonkey/source/embedding/qa/testembed/
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•